git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 01/11] trace: move trace declarations from cache.h to new trace.h

From
Karsten Blees <karsten.blees@gmail.com>
Date
Jun 11, 2014, 07:56 UTC
Message-ID
<53980BC1.3000109@gmail.com>
In-Reply-To
<53980B83.9050409@gmail.com>

Also include direct dependencies (strbuf.h and git-compat-util.h for __attribute__) so that trace.h can be used independently of cache.h, e.g. in test programs.

Signed-off-by: Karsten Blees <blees@dcon.de>
---
 cache.h | 13 ++-----------
 trace.h | 17 +++++++++++++++++
 2 files changed, 19 insertions(+), 11 deletions(-)
 create mode 100644 trace.h
diff --git a/cache.h b/cache.h
index 1e4b4f0..79ac940 100644
--- a/cache.h
+++ b/cache.h
@@ -7,6 +7,7 @@
 #include "advice.h"
 #include "gettext.h"
 #include "convert.h"
+#include "trace.h"
 
 #include SHA1_HEADER
 #ifndef git_SHA_CTX
@@ -1378,17 +1379,7 @@ extern void *alloc_tag_node(void);
 extern void *alloc_object_node(void);
 extern void alloc_report(void);
 
-/* trace.c */
-__attribute__((format (printf, 1, 2)))
-extern void trace_printf(const char *format, ...);
-__attribute__((format (printf, 2, 3)))
-extern void trace_argv_printf(const char **argv, const char *format, ...);
-extern void trace_repo_setup(const char *prefix);
-extern int trace_want(const char *key);
-__attribute__((format (printf, 2, 3)))
-extern void trace_printf_key(const char *key, const char *fmt, ...);
-extern void trace_strbuf(const char *key, const struct strbuf *buf);
-
+/* pkt-line.c */
 void packet_trace_identity(const char *prog);
 
 /* add */
diff --git a/trace.h b/trace.h
new file mode 100644
index 0000000..6cc4541
--- /dev/null
+++ b/trace.h
@@ -0,0 +1,17 @@
+#ifndef TRACE_H
+#define TRACE_H
+
+#include "git-compat-util.h"
+#include "strbuf.h"
+
+__attribute__((format (printf, 1, 2)))
+extern void trace_printf(const char *format, ...);
+__attribute__((format (printf, 2, 3)))
+extern void trace_argv_printf(const char **argv, const char *format, ...);
+extern void trace_repo_setup(const char *prefix);
+extern int trace_want(const char *key);
+__attribute__((format (printf, 2, 3)))
+extern void trace_printf_key(const char *key, const char *fmt, ...);
+extern void trace_strbuf(const char *key, const struct strbuf *buf);
+
+#endif /* TRACE_H */
-- 
1.9.2.msysgit.0.501.gaeecf09

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Previous: Karsten BleesNext: Karsten Blees
Message 2 of 23 in “add performance tracing facility”
  1. 00/11 add performance tracing facilityKarsten Blees, Jun 11, 2014
  2. 01/11 trace: move trace declarations from cache.h to new trace.hKarsten Blees, Jun 11, 2014
  3. 02/11 trace: consistently name the format parameterKarsten Blees, Jun 11, 2014
  4. 03/11 trace: remove redundant printf format attributeKarsten Blees, Jun 11, 2014
  5. 04/11 trace: factor out printing to the trace fileKarsten Blees, Jun 11, 2014
  6. 05/11 trace: add infrastructure to augment trace output with additional infoKarsten Blees, Jun 11, 2014
  7. 06/11 trace: add current timestamp to all trace outputKarsten Blees, Jun 11, 2014
  8. 07/11 trace: move code around, in preparation to file:line outputKarsten Blees, Jun 11, 2014
  9. 08/11 trace: add 'file:line' to all trace outputKarsten Blees, Jun 11, 2014
  10. 09/11 trace: add high resolution timer function to debug performance issuesKarsten Blees, Jun 11, 2014
  11. Karsten BleesJun 11, 2014
  12. Junio C HamanoJun 17, 2014
  13. Karsten BleesJun 18, 2014
  14. 10/11 trace: add trace_performance facility to debug performance issuesKarsten Blees, Jun 11, 2014
  15. Junio C HamanoJun 17, 2014
  16. Karsten BleesJun 18, 2014
  17. Junio C HamanoJun 18, 2014
  18. 11/11 git: add performance tracing for git's main() function to debug scriptsKarsten Blees, Jun 11, 2014
  19. Junio C HamanoJun 12, 2014
  20. Karsten BleesJun 18, 2014
  21. Duy NguyenJun 25, 2014
  22. Karsten BleesJun 25, 2014
  23. Duy NguyenJun 26, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.