git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 1/1] submodule: fix 'submodule status' when called from a subdirectory

From
Manish Goregaokar <manishsmail@gmail.com>
Date
Nov 25, 2019, 06:32 UTC
Message-ID
<CACpkpxmFK61CgOS0M_2RV7BMT1Pk6Q2XdWYzdf5LVbAvd1rnXQ@mail.gmail.com>
In-Reply-To
<xmqqmucky2wj.fsf@gitster-ct.c.googlers.com>

Thank you! -Manish Goregaokar

On Sun, Nov 24, 2019 at 8:51 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 31 quoted lines
>
> "Manish Goregaokar via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > +             test_cmp ../expect ../actual &&
>
> Note that "test_cmp expect actual" highlights a breakage, when it
> finds one, by showing a diff that shows "what we saw is different
> from what we expected to see in this way".  So this invocation is
> good.
>
> > +             git -C ../submod checkout HEAD^ &&
> > +             git submodule status >../output &&
> > +             awk "{print \$1}" <../output >../actual2 &&
> > +             cd .. &&
> > +             git submodule status >output &&
> > +             awk "{print \$1}" <output >expect2 &&
> > +             test_cmp actual2 expect2 &&
>
> But this one is probably the other way around.  I'll fix this up
> while queuing, so if there is no other changes necessary, there is
> no need to resend the patch.
>
> > +             ! test_cmp actual actual2
>
> And the order of this one actually does not matter ;-)
>
> > +     )
> > +'
>
> Thanks.
Previous: Junio C Hamano
Message 11 of 11 in “submodule: Fix 'submodule status' when called from a subdirectory”
  1. 0/1 submodule: Fix 'submodule status' when called from a subdirectoryManish Goregaokar via GitGitGadget, Nov 23, 2019
  2. 1/1 submodule: Fix 'submodule status' when called from a subdirectoryManish Goregaokar via GitGitGadget, Nov 23, 2019
  3. Junio C HamanoNov 24, 2019
  4. 0/1 submodule: Fix 'submodule status' when called from a subdirectoryManish Goregaokar via GitGitGadget, Nov 24, 2019
  5. 1/1 submodule: fix 'submodule status' when called from a subdirectoryManish Goregaokar via GitGitGadget, Nov 24, 2019
  6. Junio C HamanoNov 25, 2019
  7. Manish GoregaokarNov 25, 2019
  8. 0/1 submodule: Fix 'submodule status' when called from a subdirectoryManish Goregaokar via GitGitGadget, Nov 25, 2019
  9. 1/1 submodule: fix 'submodule status' when called from a subdirectoryManish Goregaokar via GitGitGadget, Nov 25, 2019
  10. Junio C HamanoNov 25, 2019
  11. Manish GoregaokarNov 25, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.