git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/1] submodule: Fix 'submodule status' when called from a subdirectory

From
Manish Goregaokar via GitGitGadget <gitgitgadget@gmail.com>
Date
Nov 23, 2019, 06:28 UTC
Message-ID
<pull.472.git.1574490521.gitgitgadget@gmail.com>

Previously, when calling git submodule status while in a subdirectory, it was incorrectly not detecting modified submodules and thus reporting that all of the submodules were unchanged.

This was because the submodule helper was calling diff-index with the submodule path assuming the path was relative to the current prefix directory, however the submodule path used is actually relative to the root.

This fixes the bug by setting the prefix to NULL when runningdiff-index from the helper, so that it correctly interprets the path as relative to the repository root.

Signed-off-by: Manish Goregaokar manishsmail@gmail.com
[manishsmail@gmail.com]
Manish Goregaokar (1):
  submodule: Fix 'submodule status' when called from a subdirectory
 builtin/submodule--helper.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
base-commit: 5fa0f5238b0cd46cfe7f6fa76c3f526ea98148d9
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-472%2FManishearth%2Fsubdir-status-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-472/Manishearth/subdir-status-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/472
-- 
gitgitgadget
Next: Manish Goregaokar via GitGitGadget
Message 1 of 11 in “submodule: Fix 'submodule status' when called from a subdirectory”
  1. 0/1 submodule: Fix 'submodule status' when called from a subdirectoryManish Goregaokar via GitGitGadget, Nov 23, 2019
  2. 1/1 submodule: Fix 'submodule status' when called from a subdirectoryManish Goregaokar via GitGitGadget, Nov 23, 2019
  3. Junio C HamanoNov 24, 2019
  4. 0/1 submodule: Fix 'submodule status' when called from a subdirectoryManish Goregaokar via GitGitGadget, Nov 24, 2019
  5. 1/1 submodule: fix 'submodule status' when called from a subdirectoryManish Goregaokar via GitGitGadget, Nov 24, 2019
  6. Junio C HamanoNov 25, 2019
  7. Manish GoregaokarNov 25, 2019
  8. 0/1 submodule: Fix 'submodule status' when called from a subdirectoryManish Goregaokar via GitGitGadget, Nov 25, 2019
  9. 1/1 submodule: fix 'submodule status' when called from a subdirectoryManish Goregaokar via GitGitGadget, Nov 25, 2019
  10. Junio C HamanoNov 25, 2019
  11. Manish GoregaokarNov 25, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.