Re: [PATCH v3 1/1] submodule: fix 'submodule status' when called from a subdirectory

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 25, 2019, 04:51 UTC
Message-ID: <xmqqmucky2wj.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <8dcea6b399923e931625ef09d66661e93975b93a.1574655344.git.gitgitgadget@gmail.com>

"Manish Goregaokar via GitGitGadget" <gitgitgadget@gmail.com> writes:

> +		test_cmp ../expect ../actual &&

Note that "test_cmp expect actual" highlights a breakage, when it finds one, by showing a diff that shows "what we saw is different from what we expected to see in this way". So this invocation is good.

Show 7 quoted lines

> +		git -C ../submod checkout HEAD^ &&
> +		git submodule status >../output &&
> +		awk "{print \$1}" <../output >../actual2 &&
> +		cd .. &&
> +		git submodule status >output &&
> +		awk "{print \$1}" <output >expect2 &&
> +		test_cmp actual2 expect2 &&

But this one is probably the other way around. I'll fix this up while queuing, so if there is no other changes necessary, there is no need to resend the patch.

> +		! test_cmp actual actual2

And the order of this one actually does not matter ;-)

> +	)
> +'

Thanks.