From: Manish Goregaokar <manishsmail@gmail.com>
Date: Mon, 25 Nov 2019 06:32:20 GMT
Subject: Re: [PATCH v3 1/1] submodule: fix 'submodule status' when called from a subdirectory
Message-ID: <CACpkpxmFK61CgOS0M_2RV7BMT1Pk6Q2XdWYzdf5LVbAvd1rnXQ@mail.gmail.com>
In-Reply-To: <xmqqmucky2wj.fsf@gitster-ct.c.googlers.com>

Thank you!
-Manish Goregaokar

On Sun, Nov 24, 2019 at 8:51 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> "Manish Goregaokar via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > +             test_cmp ../expect ../actual &&
>
> Note that "test_cmp expect actual" highlights a breakage, when it
> finds one, by showing a diff that shows "what we saw is different
> from what we expected to see in this way".  So this invocation is
> good.
>
> > +             git -C ../submod checkout HEAD^ &&
> > +             git submodule status >../output &&
> > +             awk "{print \$1}" <../output >../actual2 &&
> > +             cd .. &&
> > +             git submodule status >output &&
> > +             awk "{print \$1}" <output >expect2 &&
> > +             test_cmp actual2 expect2 &&
>
> But this one is probably the other way around.  I'll fix this up
> while queuing, so if there is no other changes necessary, there is
> no need to resend the patch.
>
> > +             ! test_cmp actual actual2
>
> And the order of this one actually does not matter ;-)
>
> > +     )
> > +'
>
> Thanks.