git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Revert "gitweb: Time::HiRes is in core for Perl 5.8"

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jan 29, 2012, 02:29 UTC
Message-ID
<CACBZZX4KOc6Roz7U5rLrNnzJ_JY9WsSyV6zU_KOsHC+A8y7w4w@mail.gmail.com>
In-Reply-To
<7vty3gzxhs.fsf@alter.siamese.dyndns.org>
On Fri, Jan 27, 2012 at 21:44, Junio C Hamano <gitster@pobox.com> wrote:
Show 7 quoted lines
>
>        if (defined $t0)
>
> If you go this route, even though tee-zero, the beginning of the
> time, is a good name for the variable, you may want to rename it to
> avoid confusing readers who might take it as a temporary variable
> #0.
<trivia>

Personally I'd have written it as $START_TIME, but as a bit of Perl trivia you might not realize $t0 is a commonly used and undestood variable for dealing with a start time in Perl in the same way that `i` is common for dealing with array indexes in C.

I.e. someone used to Perl will immediately think "oh that's the start time" having seen it hundreds of times before, but someone not used to Perl will go "what's this t-zero thing?".

Meanwhile some Lisp programmer is wondering what the hell "i" means in your C for-loops, iterator? :)

Previous: Jakub NarebskiNext: Ævar Arnfjörð Bjarmason
Message 12 of 13 in “Test t9500 fails if Time::HiRes is missing”
  1. Hallvard Breien FurusethJan 23, 2012
  2. Hallvard Breien FurusethJan 23, 2012
  3. Ævar Arnfjörð BjarmasonJan 23, 2012
  4. Junio C HamanoJan 27, 2012
  5. Ævar Arnfjörð BjarmasonJan 27, 2012
  6. Jakub NarębskiJan 27, 2012
  7. Hallvard B FurusethJan 27, 2012
  8. Jakub NarębskiJan 27, 2012
  9. Revert "gitweb: Time::HiRes is in core for Perl 5.8"Jakub Narebski, Jan 27, 2012
  10. Junio C HamanoJan 27, 2012
  11. Jakub NarebskiJan 28, 2012
  12. Ævar Arnfjörð BjarmasonJan 29, 2012
  13. Ævar Arnfjörð BjarmasonJan 29, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.