Re: Test t9500 fails if Time::HiRes is missing

From: Jakub Narębski <jnareb@gmail.com>
Date: Jan 27, 2012, 10:59 UTC
Message-ID: <CANQwDwfsdCGhNLQrJ5Ajz+BNdZmWEu=2b1UHmP=x0RsaZQOPrQ@mail.gmail.com>
In-Reply-To: <69c90e626682e60d33bebcc6d3ff3fdb@ulrik.uio.no>

On Fri, Jan 27, 2012 at 11:15 AM, Hallvard B Furuseth <h.b.furuseth@usit.uio.no> wrote:

Show 31 quoted lines

> On Mon, 23 Jan 2012 10:42:02 +0100, Ævar Arnfjörð Bjarmason
> <avarab@gmail.com> wrote:
>>
>> On Mon, Jan 23, 2012 at 05:50, Hallvard Breien Furuseth
>> <h.b.furuseth@usit.uio.no> wrote:
>>>
>>> Or pacify the test and expect gitweb@RHEL-users to install the RPM:
>>>
>>> --- git-1.7.9.rc2/t/gitweb-lib.sh~
>>> +++ git-1.7.9.rc2/t/gitweb-lib.sh
>>> @@ -113,4 +113,9 @@
>>>        test_done
>>>  }
>>>
>>> +perl -MTime::HiRes -e 0 >/dev/null 2>&1 || {
>>> +       skip_all='skipping gitweb tests, Time::HiRes module not available'
>>> +       test_done
>>> +}
>>> +
>>>  gitweb_init
>>
>>
>> [Adding Jakub to CC]
>>
>> This doesn't actually fix the issue, it only sweeps it under the rug
>> by making the tests pass, gitweb will still fail to compile on Red
>> Hat once installed.
>
>
> Is that relevant?  gitweb-lib.sh already has code to pass the tests if
> Encode, CGI, CGI::Util or CGI::Carp are missing.  I just added another.

The difference is that:
1.) Time::HiRes is a core Perl module, so theoretically it should be always
    installed.
2.) Time::HiRes is not really required for gitweb to work, only for optional
    feature (timing information).

-- 
Jakub Narebski