git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Test t9500 fails if Time::HiRes is missing

From
HFHallvard B Furuseth <h.b.furuseth@usit.uio.no>
Date
Jan 27, 2012, 10:15 UTC
Message-ID
<69c90e626682e60d33bebcc6d3ff3fdb@ulrik.uio.no>
In-Reply-To
<CACBZZX4cjcY5d3mPJAV+rbSTqCEUOrF=_dd3ny_jSM++G-Bg1Q@mail.gmail.com>
 On Mon, 23 Jan 2012 10:42:02 +0100, Ævar Arnfjörð Bjarmason 
 <avarab@gmail.com> wrote:
Show 23 quoted lines
> On Mon, Jan 23, 2012 at 05:50, Hallvard Breien Furuseth
> <h.b.furuseth@usit.uio.no> wrote:
>> Or pacify the test and expect gitweb@RHEL-users to install the RPM:
>>
>> --- git-1.7.9.rc2/t/gitweb-lib.sh~
>> +++ git-1.7.9.rc2/t/gitweb-lib.sh
>> @@ -113,4 +113,9 @@
>>        test_done
>>  }
>>
>> +perl -MTime::HiRes -e 0 >/dev/null 2>&1 || {
>> +       skip_all='skipping gitweb tests, Time::HiRes module not 
>> available'
>> +       test_done
>> +}
>> +
>>  gitweb_init
>
> [Adding Jakub to CC]
>
> This doesn't actually fix the issue, it only sweeps it under the rug
> by making the tests pass, gitweb will still fail to compile on Red
> Hat once installed.
 Is that relevant?  gitweb-lib.sh already has code to pass the tests if
 Encode, CGI, CGI::Util or CGI::Carp are missing.  I just added another.
-- 
 Hallvard
Previous: Jakub NarębskiNext: Jakub Narębski
Message 7 of 13 in “Test t9500 fails if Time::HiRes is missing”
  1. Hallvard Breien FurusethJan 23, 2012
  2. Hallvard Breien FurusethJan 23, 2012
  3. Ævar Arnfjörð BjarmasonJan 23, 2012
  4. Junio C HamanoJan 27, 2012
  5. Ævar Arnfjörð BjarmasonJan 27, 2012
  6. Jakub NarębskiJan 27, 2012
  7. Hallvard B FurusethJan 27, 2012
  8. Jakub NarębskiJan 27, 2012
  9. Revert "gitweb: Time::HiRes is in core for Perl 5.8"Jakub Narebski, Jan 27, 2012
  10. Junio C HamanoJan 27, 2012
  11. Jakub NarebskiJan 28, 2012
  12. Ævar Arnfjörð BjarmasonJan 29, 2012
  13. Ævar Arnfjörð BjarmasonJan 29, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.