Re: [PATCH 0/3] sparse-checkout: add 'clean' command

From: Elijah Newren <newren@gmail.com>
Date: Jul 8, 2025, 22:01 UTC
Message-ID: <CABPp-BEh5FdPSr84-YG=Bw6fBaE1P2s8Zcy5D68bSZ+_nsQrvw@mail.gmail.com>
In-Reply-To: <CABPp-BGSEsQ5Ljm4j81VUuM+_U6CJYDG64wKxj_-oEK=WVD4iw@mail.gmail.com>

On Tue, Jul 8, 2025 at 1:36 PM Elijah Newren <newren@gmail.com> wrote:

>
> On Tue, Jul 8, 2025 at 4:19 AM Derrick Stolee via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
> >

[...]

> I'm also curious what happens when (1) you are in cone mode and there
> is no sparse index, or (2) when you are not in cone mode.  I suspect
> those and the questions above will be answered as I read the
> individual patches, so I'll keep going...

After reading the series, I know the answer to (2). I think the answer to (1) is that it effectively turns into a silent (but not instantaneous) no-op, which may be confusing for users. We might want to provide them with an alternative implementation, or at least a warning or error that the mode doesn't (currently?) do anything when sparse index isn't in use.

Anyway, I think the series is a good direction and you've explained the motivation very well, but I'm a bit worried the current implementation might be using too coarse of a hammer.