Re: [PATCH 0/6] echo usernames as they are typed
- From
Erik Faye-Lund <kusmabite@gmail.com>
- Date
- Nov 27, 2011, 09:17 UTC
- Message-ID
- <CABPQNSb09kxjvdvz2P-WqU2VtMspaaA8ujTNLJ4+MuCrV=2zsw@mail.gmail.com>
- In-Reply-To
- <20111127082744.GA32068@sigill.intra.peff.net>
On Sun, Nov 27, 2011 at 9:27 AM, Jeff King <peff@peff.net> wrote:
Show 17 quoted lines
> On Thu, Nov 24, 2011 at 05:58:01AM -0500, Jeff King wrote: > >> Here's a revised version of the http-auth / credential-helper series. > > And here's something I've been meaning to do on top: actually echo > characters at the username prompt. We can't do this portably, but we can > at least stub out a compatibility layer and let each system do something > sensible. > > [1/6]: move git_getpass to its own source file > [2/6]: refactor git_getpass into generic prompt function > [3/6]: stub out getpass_echo function > [4/6]: prompt: add PROMPT_ECHO flag > [5/6]: credential: use git_prompt instead of git_getpass > [6/6]: compat/getpass: add a /dev/tty implementation > > -Peff
Interesting, I've been working on something pretty similar: getting rid of getpass usage all together:
https://github.com/kusma/git/tree/work/askpass
My reason to write a getpass replacement was to avoid capping input to PASS_MAX, which can be as low as 8 characters (and AFAIK is just that on Solaris)...