Re: [PATCH 0/6] echo usernames as they are typed
- From
Jeff King <peff@peff.net>
- Date
- Nov 28, 2011, 18:59 UTC
- Message-ID
- <20111128185956.GA28191@sigill.intra.peff.net>
- In-Reply-To
- <CABPQNSYd8PFsoRi6NtjQYNQzM+NHv_aRCLRWQ=XsFuw2gGWAng@mail.gmail.com>
On Mon, Nov 28, 2011 at 01:59:34PM +0100, Erik Faye-Lund wrote:
Show 9 quoted lines
> > Certainly on non-Windows something like that would not be welcome. The > > user can already have specified GIT_ASKPASS if they don't have a > > terminal. And once the credential-helper code is in, they can use a > > platform-specific helper that provides a nice dialog if they want it. > > > > Yes, that's certainly cleaner implementation-wise. But didn't you > change it to only do the storage-part in the last round, or did I > misunderstand the updated series?
Yeah, sorry, I'm getting ahead of myself. I left room in the spec for an "ask" operation on helpers, but I haven't implemented it yet.
-Peff