git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] INSTALL: git-p4 doesn't support Python 3

From
Brandon Casey <drafnel@gmail.com>
Date
Jan 20, 2013, 21:03 UTC
Message-ID
<CA+sFfMfCi-cvgRXE7KnPAsQpMWFR8eMiG0wQ0vL+p+U=R2R2qw@mail.gmail.com>
In-Reply-To
<20130120192831.GB7498@serenity.lan>
On Sun, Jan 20, 2013 at 11:28 AM, John Keeping <john@keeping.me.uk> wrote:
Show 9 quoted lines
> On Sun, Jan 20, 2013 at 10:54:52AM -0800, Junio C Hamano wrote:
>> John Keeping <john@keeping.me.uk> writes:
>>
>>> git-p4 supports Python 2.6 and later versions of Python 2.  Since Python
>>> 2.8 will never exist [1], it is most concise to just list the supported
>>> versions.
>>
>> Thanks; Eric's patch recently updated git-p4.py to require 2.4 I
>> think. Shouldn't it also be updated?

Actually, the script does not support python 2.4 in its current state since it uses subprocess.check_call which was introduced in python 2.5.

But, this can be trivially worked around. I made the changes in my own tree on Friday and planned to submit them after using it myself for a few days.

Personally, I prefer to continue to provide the ability to compile and
install a fully working git on platforms in common use without pulling
in additional dependencies.  At least while it's fairly easy to do so.
 So, in my opinion, git-p4 should be patched to support python 2.4 and
the comment in INSTALL should be updated.  But, this opinion should be
taken with the appropriate grain of salt since I'm not really a
contributor to any of the python infrastructure.
-Brandon
Previous: Junio C Hamano
Message 5 of 5 in “INSTALL: git-p4 doesn't support Python 3”
  1. INSTALL: git-p4 doesn't support Python 3John Keeping, Jan 20, 2013
  2. Junio C HamanoJan 20, 2013
  3. John KeepingJan 20, 2013
  4. Junio C HamanoJan 20, 2013
  5. Brandon CaseyJan 20, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.