git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] INSTALL: git-p4 doesn't support Python 3

From
John Keeping <john@keeping.me.uk>
Date
Jan 20, 2013, 19:28 UTC
Message-ID
<20130120192831.GB7498@serenity.lan>
In-Reply-To
<7vwqv7lm6b.fsf@alter.siamese.dyndns.org>
On Sun, Jan 20, 2013 at 10:54:52AM -0800, Junio C Hamano wrote:
Show 8 quoted lines
> John Keeping <john@keeping.me.uk> writes:
> 
>> git-p4 supports Python 2.6 and later versions of Python 2.  Since Python
>> 2.8 will never exist [1], it is most concise to just list the supported
>> versions.
> 
> Thanks; Eric's patch recently updated git-p4.py to require 2.4 I
> think. Shouldn't it also be updated?

I haven't done a thorough audit to check what the actual minimum supported version is, this is just the minimal change to say "not Python 3".

Personally, I'm not sure of the value of having version checks at the top of the Python scripts, I would rather set a project-wide minimum supported version (as in my recent CodingGuidelines patch) and check it once in the Makefile.

John
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 5 in “INSTALL: git-p4 doesn't support Python 3”
  1. INSTALL: git-p4 doesn't support Python 3John Keeping, Jan 20, 2013
  2. Junio C HamanoJan 20, 2013
  3. John KeepingJan 20, 2013
  4. Junio C HamanoJan 20, 2013
  5. Brandon CaseyJan 20, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.