Re: [PATCH v2] INSTALL: git-p4 doesn't support Python 3

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 20, 2013, 19:54 UTC
Message-ID: <7vd2wzljep.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130120192831.GB7498@serenity.lan>

John Keeping <john@keeping.me.uk> writes:

Show 18 quoted lines

> On Sun, Jan 20, 2013 at 10:54:52AM -0800, Junio C Hamano wrote:
>> John Keeping <john@keeping.me.uk> writes:
>> 
>>> git-p4 supports Python 2.6 and later versions of Python 2.  Since Python
>>> 2.8 will never exist [1], it is most concise to just list the supported
>>> versions.
>> 
>> Thanks; Eric's patch recently updated git-p4.py to require 2.4 I
>> think. Shouldn't it also be updated?
>
> I haven't done a thorough audit to check what the actual minimum
> supported version is, this is just the minimal change to say "not
> Python 3".
>
> Personally, I'm not sure of the value of having version checks at the
> top of the Python scripts, I would rather set a project-wide minimum
> supported version (as in my recent CodingGuidelines patch) and check it
> once in the Makefile.

OK; I'll leave that for later a day (Cc'ed Eric but stakeholders of other Python scripts may want to express their opinions), and will apply this patch as is.

If we end up deciding to rip out the "prerequisite per file", that will be a tree-wide change that is independent from your patch we are discussing in this thread. If we end up not doing that, then we would instead be updating git-p4.py to set a higher floor to the prerequiste but that can come as a separate patch.

Thanks.