git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [regression] Re: git-cat-file --batch reversion; cannot query filenames with spaces

From
Brandon Casey <drafnel@gmail.com>
Date
Aug 2, 2013, 16:14 UTC
Message-ID
<CA+sFfMdeGCfWbXfv7YqZi4zZj6RhDaugVgHJNu_Fhmx35wi=8Q@mail.gmail.com>
In-Reply-To
<20130802152713.GA23548@gnu.kitenet.net>
On Fri, Aug 2, 2013 at 8:27 AM, Joey Hess <joey@kitenet.net> wrote:
Show 18 quoted lines
> Jeff King wrote:
>> By the way, Joey, I am not sure how safe "git cat-file --batch-check" is
>> for arbitrary filenames. In particular, I don't know how it would react
>> to a filename with an embedded newline (and I do not think it will undo
>> quoting). Certainly that does not excuse this regression; even if what
>> you are doing is not 100% reliable, it is good enough in sane situations
>> and we should not be breaking it. But you may want to double-check the
>> behavior of your scripts in such a case, and we may need to add a "-z"
>> to support it reliably.
>
> Yes, I would prefer to have a -z mode. I think my code otherwise handles
> newlines.
>
> Thanks for the quick fix. I agree that only enabling the behavior with
> %{rest} makes sense.
>
> --
> see shy jo

/methinks we've identified a gap in our test coverage. Care to add a test that covers the functionality that git-annex depends on?

-Brandon
Previous: Joey HessNext: Junio C Hamano
Message 5 of 11 in “[regression] Re: git-cat-file --batch reversion; cannot query filenames with spaces”
  1. Jonathan NiederAug 2, 2013
  2. Jeff KingAug 2, 2013
  3. Jeff KingAug 2, 2013
  4. Joey HessAug 2, 2013
  5. Brandon CaseyAug 2, 2013
  6. Junio C HamanoAug 2, 2013
  7. Jeff KingAug 2, 2013
  8. Junio C HamanoAug 2, 2013
  9. Jonathan NiederAug 2, 2013
  10. Jeff KingAug 3, 2013
  11. Junio C HamanoAug 2, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.