Re: [regression] Re: git-cat-file --batch reversion; cannot query filenames with spaces
- From
Joey Hess <joey@kitenet.net>
- Date
- Aug 2, 2013, 15:27 UTC
- Message-ID
- <20130802152713.GA23548@gnu.kitenet.net>
- In-Reply-To
- <20130802115906.GA9183@sigill.intra.peff.net>
Jeff King wrote:
Show 8 quoted lines
> By the way, Joey, I am not sure how safe "git cat-file --batch-check" is > for arbitrary filenames. In particular, I don't know how it would react > to a filename with an embedded newline (and I do not think it will undo > quoting). Certainly that does not excuse this regression; even if what > you are doing is not 100% reliable, it is good enough in sane situations > and we should not be breaking it. But you may want to double-check the > behavior of your scripts in such a case, and we may need to add a "-z" > to support it reliably.
Yes, I would prefer to have a -z mode. I think my code otherwise handles newlines.
Thanks for the quick fix. I agree that only enabling the behavior with %{rest} makes sense.
-- see shy jo