Re: [regression] Re: git-cat-file --batch reversion; cannot query filenames with spaces

From: Jeff King <peff@peff.net>
Date: Aug 2, 2013, 17:28 UTC
Message-ID: <20130802172804.GB11329@sigill.intra.peff.net>
In-Reply-To: <7vtxj8oxin.fsf@alter.siamese.dyndns.org>

On Fri, Aug 02, 2013 at 09:41:52AM -0700, Junio C Hamano wrote:

Show 9 quoted lines

> > Of the two, I think the latter is more sensible; the former is
> > unnecessarily placing the burden on the user to match "--split" with
> > their use of "%(rest)". The second is pointless without the first.
> >
> > A patch to implement (2) is below.
> 
> As I'd queue this on top of the revert, I had to wrangle it a bit to
> make it relative, i.e. "this resurrects what the other reverted
> patch did but in a weaker/safer form".

Yeah, sorry. After doing the patch I had the thought that maybe the least invasive thing would be the fix rather than the straight revert (we are counting on my assertion that just reverting out part of the series will be OK; I'm pretty sure that is the case, but it is not risk-free, either).

I didn't see the result of your wrangling in pu, but I will keep an eye out to double-check it (unless you did not finish, in which case I am happy to do the wrangling myself).

-Peff