Re: [regression] Re: git-cat-file --batch reversion; cannot query filenames with spaces

From: Jeff King <peff@peff.net>
Date: Aug 2, 2013, 10:54 UTC
Message-ID: <20130802105402.GA25697@sigill.intra.peff.net>
In-Reply-To: <20130802064003.GB3013@elie.Belkin>

On Thu, Aug 01, 2013 at 11:40:03PM -0700, Jonathan Nieder wrote:

Show 18 quoted lines

> > Commit c334b87b30c1464a1ab563fe1fb8de5eaf0e5bac caused a reversion in
> > git-cat-file --batch.
> >
> > With an older version:
> >
> > joey@gnu:~/tmp/rrr>git cat-file --batch
> > :file name
> > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 blob 0
> >
> > With the new version:
> >
> > joey@wren:~/tmp/r>git cat-file --batch
> > :file name
> > :file missing
> [...]
> Oh dear.  Luckily you caught this before the final 1.8.4 release.  I
> wonder if we should just revert c334b87b (cat-file: split --batch
> input lines on whitespace, 2013-07-11) for now.

Ugh. Yeah, the incorrect assumption from the commit message of c334b87b is "Object names cannot contain spaces...". Refs cannot, but filename specifiers after a colon can.

We need to revert that commit before the release. It can either be replaced with:

  1. A "--split" (or similar) option to use the behavior only when
     desired.

  2. Enabling splitting only when %(rest) is used in the output format.

And I suppose it is too late in the cycle for either of those to go into v1.8.4. That's a shame, but I think losing that particular patch does not affect the rest of the series, so we are OK to ship without it.

Thanks Joey for a timely bug report.

-Peff