git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC Patch v7 4/8] repo: add path.hooks with absolute and relative suffixes

From
K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
Date
Nov 3, 2026, 02:31 UTC
Message-ID
<CA+rGoLeSfwSQs6hOyGxjRhyCLqjWBMQ4yfXUYWiCz+MHqsgWAA@mail.gmail.com>
In-Reply-To
<aukHlEd5udC1gLYZ@denethor>
On Tue, Nov 3, 2026 at 4:02 AM Justin Tobler <jltobler@gmail.com> wrote:
Show 53 quoted lines
>
> On 26/09/27 05:14PM, K Jayatheerth wrote:
> > Hooks are an integral part of a repository's configuration and are
> > commonly used by tooling to automate repository-specific workflows.
> > Currently, scripts typically retrieve the hooks directory by invoking
> > `git rev-parse --git-path hooks`.
> >
> > Introduce `path.hooks.absolute` and `path.hooks.relative` keys to
> > `git repo info`. This exposes the hooks directory as a scriptable
> > config-like key using standard format rules, allowing scripts to
> > retrieve it through the same interface as other repository path
> > information.
> >
> > Mentored-by: Justin Tobler <jltobler@gmail.com>
> > Mentored-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
> > Signed-off-by: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
> > ---
> >  Documentation/git-repo.adoc |  9 +++++++++
> >  builtin/repo.c              | 22 ++++++++++++++++++++++
> >  t/t1900-repo-info.sh        | 28 ++++++++++++++++++++++++++--
> >  3 files changed, 57 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/git-repo.adoc b/Documentation/git-repo.adoc
> > index e524a07f53..20836cf8f6 100644
> > --- a/Documentation/git-repo.adoc
> > +++ b/Documentation/git-repo.adoc
> > @@ -119,6 +119,15 @@ values that they return:
> >  `path.gitdir.relative`::
> >       The path to the Git repository directory relative to the current working directory.
> >
> > +`path.hooks.absolute`::
> > +     The canonical absolute path to the repository's hooks directory.
> > +     Respects the `core.hooksPath` configuration. If `core.hooksPath` is
> > +     set to `/dev/null`, that value is returned unchanged.
> > +
> > +`path.hooks.relative`::
> > +     The path to the repository's hooks directory relative to the current
> > +     working directory. Respects the `core.hooksPath` configuration.
>
> So if a repository has `core.hooksPath` set to "/dev/null", the relative
> path output here would be something like "../../../../dev/null". I
> recognize that this matches the current behavior:
>
>   $ git -c core.hooksPath=/dev/null rev-parse --path-format=relative --git-path hooks
>   ../../../../dev/null
>
> ...but I'm still not really convinced that is is a behavior we would
> want to carry over as it makes it harder to users to figure out when
> hooks are disabled.
>
> I would suggest we print the "/dev/null" here even when the relative
> path is requested and document the behavior.
>

I am more inclined with you, and I see how returning "/dev/null" for the relative key makes it much easier for scripts to detect when hooks are disabled.

One thing I wanted to check: in a follow-up series, Junio suggested extracting a common helper library to share implementations between `git rev-parse` and `git repo info`. If `git repo info` special-cases "/dev/null" for `path.hooks.relative` while `rev-parse --git-path hooks` continues to relative-format it, would that divergence be an issue for sharing the underlying helper, or should we special-case it only in the `path.hooks` getter?

Show 38 quoted lines
> [snip]
> > diff --git a/t/t1900-repo-info.sh b/t/t1900-repo-info.sh
> > index eec576a1d9..1da5db4942 100755
> > --- a/t/t1900-repo-info.sh
> > +++ b/t/t1900-repo-info.sh
> > @@ -174,7 +174,11 @@ test_repo_info_path () {
> >                       cd repo/sub &&
> >                       ROOT="$(test-tool path-utils real_path ..)" && export ROOT &&
> >                       eval "$init_command" &&
> > -                     echo "path.$field_name.absolute=$ROOT/$expected_dir" >expect &&
> > +                     case "$expected_dir" in
> > +                     /*) EXPECT_ABS="$expected_dir" ;;
> > +                     *) EXPECT_ABS="$ROOT/$expected_dir" ;;
> > +                     esac &&
> > +                     echo "path.$field_name.absolute=$EXPECT_ABS" >expect &&
> >                       git repo info "path.$field_name.absolute" >actual &&
> >                       test_cmp expect actual
> >               )
> > @@ -188,7 +192,11 @@ test_repo_info_path () {
> >                       cd repo/sub &&
> >                       ROOT="$(test-tool path-utils real_path ..)" && export ROOT &&
> >                       eval "$init_command" &&
> > -                     echo "path.$field_name.relative=../$expected_dir" >expect &&
> > +                     case "$expected_dir" in
> > +                     /*) EXPECT_REL="$(test-tool path-utils relative_path "$expected_dir" "$PWD")" ;;
> > +                     *) EXPECT_REL="../$expected_dir" ;;
> > +                     esac &&
> > +                     echo "path.$field_name.relative=$EXPECT_REL" >expect &&
> >                       git repo info "path.$field_name.relative" >actual &&
> >                       test_cmp expect actual
> >               )
>
> From what I can gather, the code changes to this test helper is really
> only required for the "/dev/null" test case. IMO, this helper function
> has now become quite unwieldy and rather difficult to parse.
>
> I think we would be better off writing the "/dev/null" test case by hand.
>

Agreed, reverting the changes to `test_repo_info_path` and writing the `/dev/null` test as a standalone test block will be much cleaner.

Show 26 quoted lines
> > @@ -213,6 +221,22 @@ test_repo_info_path 'gitdir with explicit GIT_DIR' 'gitdir' \
> >       '.git' \
> >       'GIT_DIR="../.git" && export GIT_DIR'
> >
> > +test_repo_info_path 'hooks standard' 'hooks' '.git/hooks'
> > +
> > +test_repo_info_path 'hooks with core.hooksPath override' 'hooks' \
> > +     'custom-hooks' \
> > +     'git config core.hooksPath "$ROOT/custom-hooks" && mkdir -p "$ROOT/custom-hooks"'
> > +
> > +# /dev/null is not a real, canonicalizable filesystem path on Windows,
> > +# so path resolution for core.hooksPath=/dev/null cannot be expected to
> > +# produce a literal "/dev/null" the way it does on POSIX systems.
> > +if ! test_have_prereq MINGW
> > +then
> > +     test_repo_info_path 'hooks with core.hooksPath=/dev/null' 'hooks' \
> > +             '/dev/null' \
> > +             'git config core.hooksPath /dev/null'
> > +fi
>
> I'm not quite sure I follow here. Are we saying that the git-repo-info
> command won't work on windows if the hooks are set to "/dev/null"? Or is
> it just some issue with how the test is written? If its the latter,
> maybe this is something we can work around if the test is written
> without the use of the `test_repo_info_path` helper?
>

It was both the command and the test helper on Windows, `/dev/null` is not an actual filesystem path, so passing it through `format_path()` (and `test-tool path-utils relative_path` in the test) does not resolve the same way as on POSIX systems (where `$PWD` on Windows has a drive letter like `C:/...`).

However, if we special-case `/dev/null` in the C code so that both `path.hooks.absolute` and `path.hooks.relative` output `/dev/null` directly without passing it through `format_path()`, and write the test by hand, it will work consistently on Windows too and we can drop the `!MINGW` prerequisite entirely.

> -Justin
Thank you,
- K Jayatheerth
Previous: Justin ToblerNext: Justin Tobler
Message 96 of 135 in “repo: add more path keys to git repo info”
  1. 0/7 repo: add more path keys to git repo infoK Jayatheerth, Jul 16, 2026
  2. 1/7 repo: add path.toplevel with absolute and relative suffix formattingK Jayatheerth, Jul 16, 2026
  3. Lucas Seiki OshiroAug 15, 2026
  4. K JayatheerthAug 18, 2026
  5. 2/7 repo: add path.superproject-working-tree with absolute and relative suffixesK Jayatheerth, Jul 16, 2026
  6. 3/7 repo: add path.objects with absolute and relative suffix formattingK Jayatheerth, Jul 16, 2026
  7. 4/7 repo: add path.hooks with absolute and relative suffix formattingK Jayatheerth, Jul 16, 2026
  8. 5/7 repo: add path.index with absolute and relative suffix formattingK Jayatheerth, Jul 16, 2026
  9. 6/7 repo: add path.grafts with absolute and relative suffix formattingK Jayatheerth, Jul 16, 2026
  10. 7/7 repo: add path.git-prefix path key validationK Jayatheerth, Jul 16, 2026
  11. Junio C HamanoJul 16, 2026
  12. K JayatheerthJul 16, 2026
  13. 0/7 repo: add more path keys to git repo infoK Jayatheerth, Jul 17, 2026
  14. 1/7 repo: add path.toplevel with absolute and relative suffix formattingK Jayatheerth, Jul 17, 2026
  15. 2/7 repo: add path.superproject-working-tree with absolute and relative suffixesK Jayatheerth, Jul 17, 2026
  16. 3/7 repo: add path.objects with absolute and relative suffix formattingK Jayatheerth, Jul 17, 2026
  17. 4/7 repo: add path.hooks with absolute and relative suffix formattingK Jayatheerth, Jul 17, 2026
  18. 5/7 repo: add path.index with absolute and relative suffix formattingK Jayatheerth, Jul 17, 2026
  19. Lucas Seiki OshiroJul 20, 2026
  20. K JayatheerthJul 24, 2026
  21. Junio C HamanoJul 24, 2026
  22. 6/7 repo: add path.grafts with absolute and relative suffix formattingK Jayatheerth, Jul 17, 2026
  23. Lucas Seiki OshiroJul 20, 2026
  24. Junio C HamanoJul 20, 2026
  25. K JayatheerthJul 21, 2026
  26. 7/7 repo: add path.git-prefix path keyK Jayatheerth, Jul 17, 2026
  27. 0/7 repo: add more path keys to git repo infoK Jayatheerth, Jul 26, 2026
  28. 1/7 repo: add path.toplevel with absolute and relative suffix formattingK Jayatheerth, Jul 26, 2026
  29. Junio C HamanoJul 27, 2026
  30. K JayatheerthJul 28, 2026
  31. Justin ToblerJul 28, 2026
  32. K JayatheerthJul 29, 2026
  33. 2/7 repo: add path.superproject-working-tree with absolute and relative suffixesK Jayatheerth, Jul 26, 2026
  34. Justin ToblerJul 28, 2026
  35. 3/7 repo: add path.objects with absolute and relative suffix formattingK Jayatheerth, Jul 26, 2026
  36. Justin ToblerJul 28, 2026
  37. 4/7 repo: add path.hooks with absolute and relative suffix formattingK Jayatheerth, Jul 26, 2026
  38. Justin ToblerJul 28, 2026
  39. 5/7 repo: add path.index with absolute and relative suffix formattingK Jayatheerth, Jul 26, 2026
  40. 6/7 repo: add path.grafts with absolute and relative suffix formattingK Jayatheerth, Jul 26, 2026
  41. 7/7 repo: add path.git-prefix path keyK Jayatheerth, Jul 26, 2026
  42. Junio C HamanoJul 26, 2026
  43. K JayatheerthJul 26, 2026
  44. Lucas Seiki OshiroJul 27, 2026
  45. Junio C HamanoJul 27, 2026
  46. 0/7 repo: add more path keys to git repo infoK Jayatheerth, Aug 6, 2026
  47. 1/7 repo: add path.toplevel with absolute and relative suffix formattingK Jayatheerth, Aug 6, 2026
  48. 2/7 repo: add path.superproject-root with absolute and relative suffixesK Jayatheerth, Aug 6, 2026
  49. 3/7 repo: add path.hooks with absolute and relative suffixesK Jayatheerth, Aug 6, 2026
  50. 4/7 repo: add path.index with absolute and relative suffixesK Jayatheerth, Aug 6, 2026
  51. 5/7 repo: add path.grafts with absolute and relative suffixesK Jayatheerth, Aug 6, 2026
  52. 6/7 repo: add path.git-prefixK Jayatheerth, Aug 6, 2026
  53. Lucas Seiki OshiroAug 16, 2026
  54. K JayatheerthAug 18, 2026
  55. Junio C HamanoAug 18, 2026
  56. K JayatheerthAug 21, 2026
  57. 7/7 repo: remove unused setup.h includeK Jayatheerth, Aug 6, 2026
  58. 0/7 add more path keys to git repo infoK Jayatheerth, Aug 25, 2026
  59. 1/7 repo: add path.toplevel with absolute and relative suffix formattingK Jayatheerth, Aug 25, 2026
  60. 2/7 repo: add path.superproject-root with absolute and relative suffixesK Jayatheerth, Aug 25, 2026
  61. Junio C HamanoSep 4, 2026
  62. K JayatheerthSep 5, 2026
  63. 3/7 repo: add path.hooks with absolute and relative suffixesK Jayatheerth, Aug 25, 2026
  64. 4/7 repo: add path.index with absolute and relative suffixesK Jayatheerth, Aug 25, 2026
  65. 5/7 repo: add path.grafts with absolute and relative suffixesK Jayatheerth, Aug 25, 2026
  66. 6/7 repo: add path.git-prefixK Jayatheerth, Aug 25, 2026
  67. 7/7 repo: add path.cdupK Jayatheerth, Aug 25, 2026
  68. Junio C HamanoAug 25, 2026
  69. K JayatheerthSep 4, 2026
  70. SZEDER GáborAug 26, 2026
  71. Junio C HamanoAug 26, 2026
  72. 0/7 add more path keys to git repo infoK Jayatheerth, Sep 11, 2026
  73. 1/7 repo: add path.toplevel with absolute and relative suffix formattingK Jayatheerth, Sep 11, 2026
  74. 2/7 repo: add path.superproject-root with absolute and relative suffixesK Jayatheerth, Sep 11, 2026
  75. Junio C HamanoSep 11, 2026
  76. K JayatheerthSep 23, 2026
  77. 3/7 repo: add path.hooks with absolute and relative suffixesK Jayatheerth, Sep 11, 2026
  78. 4/7 repo: add path.index with absolute and relative suffixesK Jayatheerth, Sep 11, 2026
  79. Junio C HamanoSep 11, 2026
  80. K JayatheerthSep 23, 2026
  81. 5/7 repo: add path.grafts with absolute and relative suffixesK Jayatheerth, Sep 11, 2026
  82. 6/7 repo: add path.git-prefixK Jayatheerth, Sep 11, 2026
  83. 7/7 repo: add path.cdupK Jayatheerth, Sep 11, 2026
  84. Junio C HamanoSep 11, 2026
  85. K JayatheerthSep 23, 2026
  86. 0/8 add more path keys to git repo infoK Jayatheerth, Sep 27, 2026
  87. 1/8 repo: add path.toplevel with absolute and relative suffix formattingK Jayatheerth, Sep 27, 2026
  88. 2/8 submodule: use repository to find superprojectK Jayatheerth, Sep 27, 2026
  89. Justin ToblerNov 2, 2026
  90. K JayatheerthNov 3, 2026
  91. 3/8 repo: add path.superproject-root with absolute and relative suffixesK Jayatheerth, Sep 27, 2026
  92. Justin ToblerNov 2, 2026
  93. K JayatheerthNov 3, 2026
  94. 4/8 repo: add path.hooks with absolute and relative suffixesK Jayatheerth, Sep 27, 2026
  95. Justin ToblerNov 2, 2026
  96. K JayatheerthNov 3, 2026
  97. Justin ToblerNov 3, 2026
  98. K JayatheerthNov 3, 2026
  99. 5/8 repo: add path.index with absolute and relative suffixesK Jayatheerth, Sep 27, 2026
  100. 6/8 repo: add path.grafts with absolute and relative suffixesK Jayatheerth, Sep 27, 2026
  101. Justin ToblerNov 2, 2026
  102. K JayatheerthNov 3, 2026
  103. 7/8 repo: add path.git-prefixK Jayatheerth, Sep 27, 2026
  104. 8/8 repo: add path.cdupK Jayatheerth, Sep 27, 2026
  105. Justin ToblerNov 2, 2026
  106. K JayatheerthNov 3, 2026
  107. Junio C HamanoNov 1, 2026
  108. Justin ToblerNov 1, 2026
  109. Junio C HamanoNov 2, 2026
  110. 0/7 repo: add path keys to repo infoK Jayatheerth, Nov 7, 2026
  111. 1/7 repo: add path.toplevel with absolute and relative suffix formattingK Jayatheerth, Nov 7, 2026
  112. 2/7 submodule: use repository to find superprojectK Jayatheerth, Nov 7, 2026
  113. 3/7 repo: add path.superproject-root with absolute and relative suffixesK Jayatheerth, Nov 7, 2026
  114. 4/7 repo: add path.hooks with absolute and relative suffixesK Jayatheerth, Nov 7, 2026
  115. 5/7 repo: add path.index with absolute and relative suffixesK Jayatheerth, Nov 7, 2026
  116. 6/7 repo: add path.git-prefixK Jayatheerth, Nov 7, 2026
  117. 7/7 repo: add path.cdupK Jayatheerth, Nov 7, 2026
  118. Phillip WoodNov 7, 2026
  119. K JayatheerthNov 9, 2026
  120. Junio C HamanoNov 9, 2026
  121. Phillip WoodNov 10, 2026
  122. K JayatheerthNov 11, 2026
  123. Phillip WoodNov 10, 2026
  124. K JayatheerthNov 11, 2026
  125. Phillip WoodNov 11, 2026
  126. 0/5 repo: add path keys to repo infoK Jayatheerth, Nov 14, 2026
  127. 1/5 repo: add path.workingtree with absolute and relative suffix formattingK Jayatheerth, Nov 14, 2026
  128. 2/5 submodule: use repository to find superprojectK Jayatheerth, Nov 14, 2026
  129. 3/5 repo: add path.superprojectworkingtree with absolute and relative suffixesK Jayatheerth, Nov 14, 2026
  130. 4/5 repo: add path.index with absolute and relative suffixesK Jayatheerth, Nov 14, 2026
  131. 5/5 repo: add path.prefixK Jayatheerth, Nov 14, 2026
  132. Phillip WoodNov 15, 2026
  133. K JayatheerthNov 15, 2026
  134. Phillip WoodNov 15, 2026
  135. K JayatheerthNov 16, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.