Re: [GSoC Patch v3 0/7] repo: add more path keys to git repo info

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 27, 2026, 05:55 UTC
Message-ID: <xmqqpl09ou1u.fsf@gitster.g>
In-Reply-To: <8933F9C6-DF8A-400D-AE1A-CC79CEB26283@gmail.com>

Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> writes:

>> I'd love to hear real reviews from others on these patches, but
>> at least I didn't spot anything glaringly wrong anymore.
>
> It looks good to me :-)

Can you try to make your review sound a bit more credible to readers?

It is much harder to give positive reviews than to merely point out a few breakages in a patch, but there are still things reviewers can do. Thinking aloud to follow the author's line of thought is a technique I have found over the years to work well in demonstrating that your Ack is backed by having actually read and understood the patch. There may be other techniques experienced reviewers (by now you know who they are after reading what they wrote on your patches and others') use when giving positive reviews.

Thanks.