git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC Patch v8 0/7] repo: add path keys to repo info

From
K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
Date
Nov 11, 2026, 09:03 UTC
Message-ID
<CA+rGoLc0Mc82fTL85t6BRcGUJ8+S6cFfu0kzpxqUyjyShQW7UA@mail.gmail.com>
In-Reply-To
<f7489c12-8529-4d0b-b820-225c9ee4d297@gmail.com>
On Tue, Nov 10, 2026 at 8:10 PM Phillip Wood <phillip.wood123@gmail.com> wrote:
Show 57 quoted lines
>
> On 09/11/2026 16:52, K Jayatheerth wrote:
> > On Sun, Nov 8, 2026 at 1:27 AM Phillip Wood <phillip.wood123@gmail.com> wrote:
> >>>
> >>> The path keys added in this series are:
> >>>     - `path.toplevel.absolute` / `path.toplevel.relative`: The root directory
> >>>       of the working tree (or an empty string in bare repositories).
> >>
> >> In our documentation and glossary, we call this directory the "working
> >> tree" so I think "path.working-tree.*" would be a better name, rather
> >> than copying the name from the equivalent rev-parse option.
> >>
> >>>     - `path.superproject-root.absolute` / `path.superproject-root.relative`:
> >>>       The root of the superproject when inside a submodule.
> >>
> >> Personally, I'd prefer "path.superproject-working-tree.*" here, though I
> >> see Justin thought that was a bit of a mouthful. As this command is for
> >> use in scripts I'd rather have a descriptive name.
> >>
> >
> > I don't have an opinion on the name itself, but, that said:
> > I think superproject-working-tree is a more suiting name.
> > It is becuase you may have a working tree in a different place and it
> > might not be the root itself.
> > I think the same logic applies for toplevel too.
> >
> > Any more thoughts from Justin, Lucas, Junio or any other reviewer
> > would be better I reckon.
>
> Yes, that would be helpful
>
> >>>     - `path.hooks.absolute` / `path.hooks.relative`: The repository's hooks
> >>>       directory (respecting `core.hooksPath`, including `/dev/null`).
> >>
> >> Given we have config based hooks now, do we really want to add this?
> >> Scripts that want to run hooks should be using "git hook run" and
> >> scripts that want to install hooks should be using the config based
> >> hooks so that they co-exist with the user's existing hooks.
> >>
> >
> > I believe that is a fair point for new tooling, though wouldn't many
> > existing scripts
> > and third-party tools still learn about hooks directly via `git
> > rev-parse --git-path hooks`?
> >
> > Since the main goal of `git repo info` is to provide an alternative
> > to `rev-parse`'s various path flags, `path.hooks` still seems useful for scripts
> > migrating over, unless the consensus is to deprecate querying the hooks
> > directory altogether.
>
> Isn't the goal to provide a better interface than rev-parse, rather than
> just porting the various path related options across unchanged? My worry
> is that by adding "path.hooks.*" we're encouraging people to use an
> outdated interface that ignores the existence of config based hooks.
> Anyone who wants to keep using "git rev-parse --git-path hooks" can do
> so, but I'd rather we didn't encourage that pattern by supporting it in
> new commands.

Well, rev-parse is one way people can use it to access, so sure, I will drop this patch.

Show 30 quoted lines
> >>>     - `path.cdup`: The relative path from the current directory up to the
> >>>       worktree root.
> >>
> >> How does this differ from path.working-tree.relative? I've never really
> >> understood "git rev-parse --cdup" - if you're in the repository root
> >> directory, 'cd "$(git rev-parse --cdup)"' dumps you in your home
> >> directory which has always seemed a bit surprising to me.
> >>
> >
> > Well looking at the code itself
> > What I can say is I find couple of edge cases,
> >
> > The cdup command relies on a slash counting loop on the prefix string
> > to output directory-up
> > sequences like '../', returns an empty string at the root and falls
> > back to the worktree path when outside.
> >
> > On the contrary, relative formatting uses Git's path utility library
> > to compute true relative
> > filesystem paths, outputting '.' at the root instead of leaving it blank.
>
> Right - but what practical benefit does "path.cdup" offer over
> "path.working-tree.relative"? "git rev-parse --cdup" was added in
> 5f94c730f3 (rev-parse: --show-cdup, 2005-12-22), four years before
> "--show-toplevel" in 7cceca5ccc (Add 'git rev-parse --show-toplevel'
> option., 2010-01-12) and 15 years before support for relative paths in
> fac60b8925 (rev-parse: add option for absolute or relative path
> formatting, 2020-12-13). So when it was added "--cdup" was the only way
> to find the root of the repository working tree, which is not the case now.
>

Well, you are right, it adds nothing new per se. I was replicating rev-parse without any benefit in both these cases.

Same logic applies, I will drop both these patches.
> Thanks
>
> Phillip
>
Thanks for the review Phillip!
Regards,
- K Jayatheerth
Previous: Phillip WoodNext: Phillip Wood
Message 124 of 135 in “repo: add more path keys to git repo info”
  1. 0/7 repo: add more path keys to git repo infoK Jayatheerth, Jul 16, 2026
  2. 1/7 repo: add path.toplevel with absolute and relative suffix formattingK Jayatheerth, Jul 16, 2026
  3. Lucas Seiki OshiroAug 15, 2026
  4. K JayatheerthAug 18, 2026
  5. 2/7 repo: add path.superproject-working-tree with absolute and relative suffixesK Jayatheerth, Jul 16, 2026
  6. 3/7 repo: add path.objects with absolute and relative suffix formattingK Jayatheerth, Jul 16, 2026
  7. 4/7 repo: add path.hooks with absolute and relative suffix formattingK Jayatheerth, Jul 16, 2026
  8. 5/7 repo: add path.index with absolute and relative suffix formattingK Jayatheerth, Jul 16, 2026
  9. 6/7 repo: add path.grafts with absolute and relative suffix formattingK Jayatheerth, Jul 16, 2026
  10. 7/7 repo: add path.git-prefix path key validationK Jayatheerth, Jul 16, 2026
  11. Junio C HamanoJul 16, 2026
  12. K JayatheerthJul 16, 2026
  13. 0/7 repo: add more path keys to git repo infoK Jayatheerth, Jul 17, 2026
  14. 1/7 repo: add path.toplevel with absolute and relative suffix formattingK Jayatheerth, Jul 17, 2026
  15. 2/7 repo: add path.superproject-working-tree with absolute and relative suffixesK Jayatheerth, Jul 17, 2026
  16. 3/7 repo: add path.objects with absolute and relative suffix formattingK Jayatheerth, Jul 17, 2026
  17. 4/7 repo: add path.hooks with absolute and relative suffix formattingK Jayatheerth, Jul 17, 2026
  18. 5/7 repo: add path.index with absolute and relative suffix formattingK Jayatheerth, Jul 17, 2026
  19. Lucas Seiki OshiroJul 20, 2026
  20. K JayatheerthJul 24, 2026
  21. Junio C HamanoJul 24, 2026
  22. 6/7 repo: add path.grafts with absolute and relative suffix formattingK Jayatheerth, Jul 17, 2026
  23. Lucas Seiki OshiroJul 20, 2026
  24. Junio C HamanoJul 20, 2026
  25. K JayatheerthJul 21, 2026
  26. 7/7 repo: add path.git-prefix path keyK Jayatheerth, Jul 17, 2026
  27. 0/7 repo: add more path keys to git repo infoK Jayatheerth, Jul 26, 2026
  28. 1/7 repo: add path.toplevel with absolute and relative suffix formattingK Jayatheerth, Jul 26, 2026
  29. Junio C HamanoJul 27, 2026
  30. K JayatheerthJul 28, 2026
  31. Justin ToblerJul 28, 2026
  32. K JayatheerthJul 29, 2026
  33. 2/7 repo: add path.superproject-working-tree with absolute and relative suffixesK Jayatheerth, Jul 26, 2026
  34. Justin ToblerJul 28, 2026
  35. 3/7 repo: add path.objects with absolute and relative suffix formattingK Jayatheerth, Jul 26, 2026
  36. Justin ToblerJul 28, 2026
  37. 4/7 repo: add path.hooks with absolute and relative suffix formattingK Jayatheerth, Jul 26, 2026
  38. Justin ToblerJul 28, 2026
  39. 5/7 repo: add path.index with absolute and relative suffix formattingK Jayatheerth, Jul 26, 2026
  40. 6/7 repo: add path.grafts with absolute and relative suffix formattingK Jayatheerth, Jul 26, 2026
  41. 7/7 repo: add path.git-prefix path keyK Jayatheerth, Jul 26, 2026
  42. Junio C HamanoJul 26, 2026
  43. K JayatheerthJul 26, 2026
  44. Lucas Seiki OshiroJul 27, 2026
  45. Junio C HamanoJul 27, 2026
  46. 0/7 repo: add more path keys to git repo infoK Jayatheerth, Aug 6, 2026
  47. 1/7 repo: add path.toplevel with absolute and relative suffix formattingK Jayatheerth, Aug 6, 2026
  48. 2/7 repo: add path.superproject-root with absolute and relative suffixesK Jayatheerth, Aug 6, 2026
  49. 3/7 repo: add path.hooks with absolute and relative suffixesK Jayatheerth, Aug 6, 2026
  50. 4/7 repo: add path.index with absolute and relative suffixesK Jayatheerth, Aug 6, 2026
  51. 5/7 repo: add path.grafts with absolute and relative suffixesK Jayatheerth, Aug 6, 2026
  52. 6/7 repo: add path.git-prefixK Jayatheerth, Aug 6, 2026
  53. Lucas Seiki OshiroAug 16, 2026
  54. K JayatheerthAug 18, 2026
  55. Junio C HamanoAug 18, 2026
  56. K JayatheerthAug 21, 2026
  57. 7/7 repo: remove unused setup.h includeK Jayatheerth, Aug 6, 2026
  58. 0/7 add more path keys to git repo infoK Jayatheerth, Aug 25, 2026
  59. 1/7 repo: add path.toplevel with absolute and relative suffix formattingK Jayatheerth, Aug 25, 2026
  60. 2/7 repo: add path.superproject-root with absolute and relative suffixesK Jayatheerth, Aug 25, 2026
  61. Junio C HamanoSep 4, 2026
  62. K JayatheerthSep 5, 2026
  63. 3/7 repo: add path.hooks with absolute and relative suffixesK Jayatheerth, Aug 25, 2026
  64. 4/7 repo: add path.index with absolute and relative suffixesK Jayatheerth, Aug 25, 2026
  65. 5/7 repo: add path.grafts with absolute and relative suffixesK Jayatheerth, Aug 25, 2026
  66. 6/7 repo: add path.git-prefixK Jayatheerth, Aug 25, 2026
  67. 7/7 repo: add path.cdupK Jayatheerth, Aug 25, 2026
  68. Junio C HamanoAug 25, 2026
  69. K JayatheerthSep 4, 2026
  70. SZEDER GáborAug 26, 2026
  71. Junio C HamanoAug 26, 2026
  72. 0/7 add more path keys to git repo infoK Jayatheerth, Sep 11, 2026
  73. 1/7 repo: add path.toplevel with absolute and relative suffix formattingK Jayatheerth, Sep 11, 2026
  74. 2/7 repo: add path.superproject-root with absolute and relative suffixesK Jayatheerth, Sep 11, 2026
  75. Junio C HamanoSep 11, 2026
  76. K JayatheerthSep 23, 2026
  77. 3/7 repo: add path.hooks with absolute and relative suffixesK Jayatheerth, Sep 11, 2026
  78. 4/7 repo: add path.index with absolute and relative suffixesK Jayatheerth, Sep 11, 2026
  79. Junio C HamanoSep 11, 2026
  80. K JayatheerthSep 23, 2026
  81. 5/7 repo: add path.grafts with absolute and relative suffixesK Jayatheerth, Sep 11, 2026
  82. 6/7 repo: add path.git-prefixK Jayatheerth, Sep 11, 2026
  83. 7/7 repo: add path.cdupK Jayatheerth, Sep 11, 2026
  84. Junio C HamanoSep 11, 2026
  85. K JayatheerthSep 23, 2026
  86. 0/8 add more path keys to git repo infoK Jayatheerth, Sep 27, 2026
  87. 1/8 repo: add path.toplevel with absolute and relative suffix formattingK Jayatheerth, Sep 27, 2026
  88. 2/8 submodule: use repository to find superprojectK Jayatheerth, Sep 27, 2026
  89. Justin ToblerNov 2, 2026
  90. K JayatheerthNov 3, 2026
  91. 3/8 repo: add path.superproject-root with absolute and relative suffixesK Jayatheerth, Sep 27, 2026
  92. Justin ToblerNov 2, 2026
  93. K JayatheerthNov 3, 2026
  94. 4/8 repo: add path.hooks with absolute and relative suffixesK Jayatheerth, Sep 27, 2026
  95. Justin ToblerNov 2, 2026
  96. K JayatheerthNov 3, 2026
  97. Justin ToblerNov 3, 2026
  98. K JayatheerthNov 3, 2026
  99. 5/8 repo: add path.index with absolute and relative suffixesK Jayatheerth, Sep 27, 2026
  100. 6/8 repo: add path.grafts with absolute and relative suffixesK Jayatheerth, Sep 27, 2026
  101. Justin ToblerNov 2, 2026
  102. K JayatheerthNov 3, 2026
  103. 7/8 repo: add path.git-prefixK Jayatheerth, Sep 27, 2026
  104. 8/8 repo: add path.cdupK Jayatheerth, Sep 27, 2026
  105. Justin ToblerNov 2, 2026
  106. K JayatheerthNov 3, 2026
  107. Junio C HamanoNov 1, 2026
  108. Justin ToblerNov 1, 2026
  109. Junio C HamanoNov 2, 2026
  110. 0/7 repo: add path keys to repo infoK Jayatheerth, Nov 7, 2026
  111. 1/7 repo: add path.toplevel with absolute and relative suffix formattingK Jayatheerth, Nov 7, 2026
  112. 2/7 submodule: use repository to find superprojectK Jayatheerth, Nov 7, 2026
  113. 3/7 repo: add path.superproject-root with absolute and relative suffixesK Jayatheerth, Nov 7, 2026
  114. 4/7 repo: add path.hooks with absolute and relative suffixesK Jayatheerth, Nov 7, 2026
  115. 5/7 repo: add path.index with absolute and relative suffixesK Jayatheerth, Nov 7, 2026
  116. 6/7 repo: add path.git-prefixK Jayatheerth, Nov 7, 2026
  117. 7/7 repo: add path.cdupK Jayatheerth, Nov 7, 2026
  118. Phillip WoodNov 7, 2026
  119. K JayatheerthNov 9, 2026
  120. Junio C HamanoNov 9, 2026
  121. Phillip WoodNov 10, 2026
  122. K JayatheerthNov 11, 2026
  123. Phillip WoodNov 10, 2026
  124. K JayatheerthNov 11, 2026
  125. Phillip WoodNov 11, 2026
  126. 0/5 repo: add path keys to repo infoK Jayatheerth, Nov 14, 2026
  127. 1/5 repo: add path.workingtree with absolute and relative suffix formattingK Jayatheerth, Nov 14, 2026
  128. 2/5 submodule: use repository to find superprojectK Jayatheerth, Nov 14, 2026
  129. 3/5 repo: add path.superprojectworkingtree with absolute and relative suffixesK Jayatheerth, Nov 14, 2026
  130. 4/5 repo: add path.index with absolute and relative suffixesK Jayatheerth, Nov 14, 2026
  131. 5/5 repo: add path.prefixK Jayatheerth, Nov 14, 2026
  132. Phillip WoodNov 15, 2026
  133. K JayatheerthNov 15, 2026
  134. Phillip WoodNov 15, 2026
  135. K JayatheerthNov 16, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.