Re: [GSoC Patch v9 0/5] repo: add path keys to repo info
On 15/11/2026 11:03, K Jayatheerth wrote:
Show 22 quoted lines
> On Sun, Nov 15, 2026 at 4:03 PM Phillip Wood <phillip.wood123@gmail.com> wrote:
>> On 14/11/2026 16:37, K Jayatheerth wrote:
>>>
>>> Changes since v8:
>>> - Dropped `path.hooks` and `path.cdup`.
>>> - Renamed `path.toplevel.*` to `path.workingtree.*` to align with the
>>> standard "working tree" glossary term while avoiding hyphens in
>>> configuration variable names.
>>> - Renamed `path.superproject-root.*` to `path.superprojectworkingtree.*`
>>> to provide a descriptive name for scripts while avoiding hyphens.
>>> - Renamed `path.git-prefix` to `path.prefix` to shorten it and avoid
>>> hyphens.
>>
>> The range-diff looks good. It is a shame we're still creating a new
>> repository for each test when the majority of the tests could happily
>> run in the repository that the test framework creates for us. No one
>> else seems to mind that, even though it makes our test suite slower than
>> it needs to be, so I'd be happy if this is merged as-is.
>>
> Whoops, apologies for missing that, I made a checklist for this
> reroll, read your
> note about the tests, and completely forgot to add it to the list :)
Not to worry, it is easily done
Show 9 quoted lines
> Also there are some newly arised questions about this in my mind:
> > - I am currently writing a follow-up series to consolidate the overlapping logic
> between `repo` and `rev-parse`, and I plan to combine and clean up the tests
> there as well.
> - Three `path.*` keys were already merged in an earlier round, so updating those
> tests would require a separate commit anyway.
> > That said, I'm open to feedback and happy to switch the tests in this
> series to run in
> a single repository if you think it's worth doing now.
If you're planning some test cleanups anyway then I'm happy for the tests here to be cleaned up by a future series. I'd do whatever you think is easiest for you.
Thanks
Phillip