Re: [PATCH v2] git-gui: add mingw specific startup wrapper

From: Steffen Prohaska <prohaska@zib.de>
Date: Oct 10, 2007, 16:10 UTC
Message-ID: <BBE6D747-4CD2-4D10-914B-F3149A8591E4@zib.de>
In-Reply-To: <Pine.LNX.4.64.0710101653400.4174@racer.site>

On Oct 10, 2007, at 5:56 PM, Johannes Schindelin wrote:

Show 13 quoted lines

> On Wed, 10 Oct 2007, Steffen Prohaska wrote:
>
>> The wrapper adds the directory it is installed in to PATH.
>> This is required for the git commands implemented in shell.
>> git-gui fails to launch them if PATH is not modified.
>>
>> The wrapper script also accepts an optional command line
>> switch '--working-dir <dir>' and changes to <dir> before
>> launching the actual git-gui. This is required to implement
>> the "Git Gui Here" Explorer shell extension.
>
> It should be mentioned here that the Explorer shell extension you talk
> about is the very simple extension provided by the Inno Installer.

Yes, but it's already there. And Shawn even finds --working-dir interesting as a general feature.

Show 5 quoted lines

> I have a much larger and versatile shell extension in mind: git- 
> cheetah.
> And fixing it is probably trivial; it can both change directory to the
> current directory (sounds wrong, doesn't it?) and extend the PATH
> appropriately before calling git-gui.

I know, but it's not yet there.

> Note: the latter is not even necessary once we (correctly) add git  
> to the
> PATH in the installer.

(wrongly ;) Adding git to the PATH will only become an option. git-gui should also work if it's not added.

I comment on the PATH question in reply to another mail.

	Steffen