Re: [PATCH v2] git-gui: set NO_MSGFMT to force using pure tcl replacement in msysgit

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 10, 2007, 19:46 UTC
Message-ID: <Pine.LNX.4.64.0710102044220.4174@racer.site>
In-Reply-To: <CC4EB4CA-3BA0-4C00-8B23-31B09032CC69@zib.de>

Hi,

On Wed, 10 Oct 2007, Steffen Prohaska wrote:

Show 11 quoted lines

> On Oct 10, 2007, at 5:52 PM, Johannes Schindelin wrote:
> 
> > On Wed, 10 Oct 2007, Steffen Prohaska wrote:
> > 
> > > Shawn's git-gui Makefile supports the pure tcl replacement for 
> > > msgfmt if setting NO_MSGFMT. This patch sets the NO_MSGFMT for 
> > > msysgit.
> > 
> > Would it not be cleaner to set this in 4msysgit and export it?
> 
> What does "set this in 4msysgit" mean?

It means what you probably assumed, that we change the Makefile in /git.

> Would running 'make' in /git/git-gui/ be supported by your solution?

No, not really. Just like "make" in /git/t/ does not pick up on the NO_SYMLINKS option.

Ciao, Dscho