From: Steffen Prohaska Date: Wed, 10 Oct 2007 16:10:21 GMT Subject: Re: [PATCH v2] git-gui: add mingw specific startup wrapper Message-ID: In-Reply-To: On Oct 10, 2007, at 5:56 PM, Johannes Schindelin wrote: > On Wed, 10 Oct 2007, Steffen Prohaska wrote: > >> The wrapper adds the directory it is installed in to PATH. >> This is required for the git commands implemented in shell. >> git-gui fails to launch them if PATH is not modified. >> >> The wrapper script also accepts an optional command line >> switch '--working-dir ' and changes to before >> launching the actual git-gui. This is required to implement >> the "Git Gui Here" Explorer shell extension. > > It should be mentioned here that the Explorer shell extension you talk > about is the very simple extension provided by the Inno Installer. Yes, but it's already there. And Shawn even finds --working-dir interesting as a general feature. > I have a much larger and versatile shell extension in mind: git- > cheetah. > And fixing it is probably trivial; it can both change directory to the > current directory (sounds wrong, doesn't it?) and extend the PATH > appropriately before calling git-gui. I know, but it's not yet there. > Note: the latter is not even necessary once we (correctly) add git > to the > PATH in the installer. (wrongly ;) Adding git to the PATH will only become an option. git-gui should also work if it's not added. I comment on the PATH question in reply to another mail. Steffen