Re: [PATCH v2] git-gui: add mingw specific startup wrapper

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 10, 2007, 15:56 UTC
Message-ID: <Pine.LNX.4.64.0710101653400.4174@racer.site>
In-Reply-To: <11919995392881-git-send-email-prohaska@zib.de>

Hi,

On Wed, 10 Oct 2007, Steffen Prohaska wrote:

Show 8 quoted lines

> The wrapper adds the directory it is installed in to PATH.
> This is required for the git commands implemented in shell.
> git-gui fails to launch them if PATH is not modified.
> 
> The wrapper script also accepts an optional command line
> switch '--working-dir <dir>' and changes to <dir> before
> launching the actual git-gui. This is required to implement
> the "Git Gui Here" Explorer shell extension.

It should be mentioned here that the Explorer shell extension you talk about is the very simple extension provided by the Inno Installer.

I have a much larger and versatile shell extension in mind: git-cheetah. And fixing it is probably trivial; it can both change directory to the current directory (sounds wrong, doesn't it?) and extend the PATH appropriately before calling git-gui.

Note: the latter is not even necessary once we (correctly) add git to the 
PATH in the installer.

Ciao, Dscho