Re: [PATCH v3] Add log.abbrevCommit config variable
On Tue, May 17, 2011 at 2:50 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Care to explain why your check has to be different?
It doesn't. I thought through it poorly.
Show 11 quoted lines
> If there is no reason
> to use a different logic, then a natural thing to do is to rewrite the
> existing decoration logic and add yours like this:
>
> if (rev->pretty_given && rev->commit_format == CMIT_FMT_RAW) {
> /* "log --pretty=raw" is special */
> if (!decoration_given)
> decoration_style = 0;
> if (!abbrev_commit_given)
> rev->abbrev_commit = 0;
> }It would be lovely if you could squash that in.
Thanks,
j.
Jay Soffian <jaysoffian@gmail.com>