From: Jay Soffian <jaysoffian@gmail.com>
Date: Tue, 17 May 2011 19:08:03 GMT
Subject: Re: [PATCH v3] Add log.abbrevCommit config variable
Message-ID: <BANLkTikW2Y0iAW6jiVMN9ifvTezY+iO+bg@mail.gmail.com>
In-Reply-To: <7vy625f9fc.fsf@alter.siamese.dyndns.org>

On Tue, May 17, 2011 at 2:50 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Care to explain why your check has to be different?

It doesn't. I thought through it poorly.

> If there is no reason
> to use a different logic, then a natural thing to do is to rewrite the
> existing decoration logic and add yours like this:
>
>        if (rev->pretty_given && rev->commit_format == CMIT_FMT_RAW) {
>                /* "log --pretty=raw" is special */
>                if (!decoration_given)
>                        decoration_style = 0;
>                if (!abbrev_commit_given)
>                        rev->abbrev_commit = 0;
>        }

It would be lovely if you could squash that in.

Thanks,

j.