git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] Add log.abbrevCommit config variable

From
Jay Soffian <jaysoffian@gmail.com>
Date
May 16, 2011, 05:53 UTC
Message-ID
<BANLkTi=iFgJ12=_amoxT8x+hNMEhQtOVBg@mail.gmail.com>
In-Reply-To
<7vei3zoab9.fsf@alter.siamese.dyndns.org>
On Sun, May 15, 2011 at 6:42 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 12 quoted lines
> I am not entirely happy about this change. The "ditto" refers to an ugly
> workaround we had to add with 4f62c2b (log.decorate: only ignore it under
> "log --pretty=raw", 2010-04-08) only because it was too late to revert the
> change in 72d9b22 (Merge branch 'sd/log-decorate', 2010-05-08) that was
> about to become part of 1.7.2-rc0 release. If we knew better, we probably
> wouldn't have added the log.decorate variable that requires this hack that
> requires us to say that 'log --pretty=raw' is special.
>
> If we stop before adding a new configuration, we do not have to repeat the
> same mistake we made earlier.
>
> I dunno.

I disagree that log.decorate is a mistake and that the workaround is ugly. It would be nice if we didn't need the workaround, but I don't think we should have to tie our hands because there are scripts that are parsing git log's output. I think it's a pragmatic solution to remaining backwards compatible while still being able to provide new functionality.

FWIW, I use log.decorate, and I'd like to be able to use log.abbrevCommit.
j.
Previous: Junio C HamanoNext: Jonathan Nieder
Message 13 of 22 in “Add log.abbrev-commit config option”
  1. Add log.abbrev-commit config optionJay Soffian, May 14, 2011
  2. Jay SoffianMay 14, 2011
  3. Jonathan NiederMay 14, 2011
  4. Jay SoffianMay 14, 2011
  5. add, merge, diff: do not use strcasecmp to compare config variable namesJonathan Nieder, May 14, 2011
  6. Junio C HamanoMay 15, 2011
  7. Add log.abbrevCommit config variableJay Soffian, May 14, 2011
  8. Jonathan NiederMay 14, 2011
  9. Jay SoffianMay 14, 2011
  10. Add log.abbrevCommit config variableJay Soffian, May 14, 2011
  11. Jay SoffianMay 15, 2011
  12. Junio C HamanoMay 15, 2011
  13. Jay SoffianMay 16, 2011
  14. Jonathan NiederMay 16, 2011
  15. Jay SoffianMay 16, 2011
  16. Junio C HamanoMay 17, 2011
  17. Junio C HamanoMay 17, 2011
  18. Jay SoffianMay 18, 2011
  19. Junio C HamanoMay 17, 2011
  20. Jay SoffianMay 17, 2011
  21. Junio C HamanoMay 15, 2011
  22. Michael J GruberMay 16, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.