git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] add, merge, diff: do not use strcasecmp to compare config variable names

From
Junio C Hamano <junio@pobox.com>
Date
May 15, 2011, 01:53 UTC
Message-ID
<7vhb8wrap2.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20110514201921.GA10758@elie>
Jonathan Nieder <jrnieder@gmail.com> writes:
> The config machinery already makes section and variable names
> lowercase when parsing them, so using strcasecmp for comparison just
> feels wasteful.  No noticeable change intended.

A quick "grep 'strcasecmp(va*r*, "[^"]*\.' yields exactly the ones covered by this patch.

Thanks, I've been meaning to change these while reading merge-recursive.
Previous: Jonathan NiederNext: Jay Soffian
Message 6 of 22 in “Add log.abbrev-commit config option”
  1. Add log.abbrev-commit config optionJay Soffian, May 14, 2011
  2. Jay SoffianMay 14, 2011
  3. Jonathan NiederMay 14, 2011
  4. Jay SoffianMay 14, 2011
  5. add, merge, diff: do not use strcasecmp to compare config variable namesJonathan Nieder, May 14, 2011
  6. Junio C HamanoMay 15, 2011
  7. Add log.abbrevCommit config variableJay Soffian, May 14, 2011
  8. Jonathan NiederMay 14, 2011
  9. Jay SoffianMay 14, 2011
  10. Add log.abbrevCommit config variableJay Soffian, May 14, 2011
  11. Jay SoffianMay 15, 2011
  12. Junio C HamanoMay 15, 2011
  13. Jay SoffianMay 16, 2011
  14. Jonathan NiederMay 16, 2011
  15. Jay SoffianMay 16, 2011
  16. Junio C HamanoMay 17, 2011
  17. Junio C HamanoMay 17, 2011
  18. Jay SoffianMay 18, 2011
  19. Junio C HamanoMay 17, 2011
  20. Jay SoffianMay 17, 2011
  21. Junio C HamanoMay 15, 2011
  22. Michael J GruberMay 16, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.