Re: [PATCH 2/5] Replace has_wildcard with PATHSPEC_NOGLOB

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Apr 10, 2011, 07:23 UTC
Message-ID: <BANLkTikT7pz_nSJRAOb3rtYePBuVc2YX0Q@mail.gmail.com>
In-Reply-To: <7vbp0fylox.fsf@alter.siamese.dyndns.org>

2011/4/10 Junio C Hamano <gitster@pobox.com>:

Show 20 quoted lines

>> +/*
>> + * Magic pathspec
>> + *
>> + * NEEDSWORK: These need to be moved to dir.h or even to a new
>> + * pathspec.h when we restructure get_pathspec() users to use the
>> + * "struct pathspec" interface.
>> + *
>> + * Possible future magic semantics include stuff like:
>> + *
>> + *   { PATHSPEC_NOGLOB, '!', "noglob" },
>> + *   { PATHSPEC_RECURSIVE, '*', "recursive" },
>> + *   { PATHSPEC_REGEXP, '\0', "regexp" },
>> + *
>> + */
>
> Gaah, why did you butcher this to heve only the whole comment and struct
> type declaration here, without moving the "Possible future magic" comment
> that clearly belongs to the structure definition you still have in dir.c
> to where it belongs?  Also if NOGLOB is no longer "Possible future", why
> is it still here?

Carelessness, I guess. Will move it (with the NOGLOB future line removed) to dir.c, close to get_pathspec().

-- 
Duy