Re: [PATCH 2/5] Replace has_wildcard with PATHSPEC_NOGLOB

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 10, 2011, 00:49 UTC
Message-ID: <7vbp0fylox.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1302368060-23827-3-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:

Show 29 quoted lines

> ---
>  cache.h     |   22 ++++++++++++++++++++--
>  dir.c       |   11 +++++++----
>  setup.c     |   17 -----------------
>  tree-walk.c |   25 ++++++++++++-------------
>  4 files changed, 39 insertions(+), 36 deletions(-)
>
> diff --git a/cache.h b/cache.h
> index 27ac8a7..da1a46c 100644
> --- a/cache.h
> +++ b/cache.h
> @@ -501,16 +501,34 @@ extern int index_name_is_other(const struct index_state *, const char *, int);
>  extern int ie_match_stat(const struct index_state *, struct cache_entry *, struct stat *, unsigned int);
>  extern int ie_modified(const struct index_state *, struct cache_entry *, struct stat *, unsigned int);
>  
> +/*
> + * Magic pathspec
> + *
> + * NEEDSWORK: These need to be moved to dir.h or even to a new
> + * pathspec.h when we restructure get_pathspec() users to use the
> + * "struct pathspec" interface.
> + *
> + * Possible future magic semantics include stuff like:
> + *
> + *	{ PATHSPEC_NOGLOB, '!', "noglob" },
> + *	{ PATHSPEC_RECURSIVE, '*', "recursive" },
> + *	{ PATHSPEC_REGEXP, '\0', "regexp" },
> + *
> + */

Gaah, why did you butcher this to heve only the whole comment and struct type declaration here, without moving the "Possible future magic" comment that clearly belongs to the structure definition you still have in dir.c to where it belongs? Also if NOGLOB is no longer "Possible future", why is it still here?