git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 5/5] grep: convert to use the new get_pathspec()

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Apr 9, 2011, 16:54 UTC
Message-ID
<1302368060-23827-6-git-send-email-pclouds@gmail.com>
In-Reply-To
<1302368060-23827-1-git-send-email-pclouds@gmail.com>
---
 builtin/grep.c |   10 +---------
 1 files changed, 1 insertions(+), 9 deletions(-)
diff --git a/builtin/grep.c b/builtin/grep.c
index 2826ca8..af16deb 100644
--- a/builtin/grep.c
+++ b/builtin/grep.c
@@ -734,7 +734,6 @@ int cmd_grep(int argc, const char **argv, const char *prefix)
 	const char *show_in_pager = NULL, *default_pager = "dummy";
 	struct grep_opt opt;
 	struct object_array list = OBJECT_ARRAY_INIT;
-	const char **paths = NULL;
 	struct pathspec pathspec;
 	struct string_list path_list = STRING_LIST_INIT_NODUP;
 	int i;
@@ -956,14 +955,7 @@ int cmd_grep(int argc, const char **argv, const char *prefix)
 			verify_filename(prefix, argv[j]);
 	}
 
-	if (i < argc)
-		paths = get_pathspec_old(prefix, argv + i);
-	else if (prefix) {
-		paths = xcalloc(2, sizeof(const char *));
-		paths[0] = prefix;
-		paths[1] = NULL;
-	}
-	init_pathspec(&pathspec, paths);
+	get_pathspec(&pathspec, prefix, argc - i, argv + i);
 	pathspec.max_depth = opt.max_depth;
 	pathspec.recursive = 1;
 
-- 
1.7.4.74.g639db
Previous: Nguyễn Thái Ngọc DuyNext: Junio C Hamano
Message 8 of 11 in “New get_pathspec()”
  1. 0/5 New get_pathspec()Nguyễn Thái Ngọc Duy, Apr 9, 2011
  2. 1/5 Rename functions in preparation for get_pathspec() restructureNguyễn Thái Ngọc Duy, Apr 9, 2011
  3. 2/5 Replace has_wildcard with PATHSPEC_NOGLOBNguyễn Thái Ngọc Duy, Apr 9, 2011
  4. Junio C HamanoApr 10, 2011
  5. Nguyen Thai Ngoc DuyApr 10, 2011
  6. 3/5 Convert prefix_pathspec() to produce struct pathspec_itemNguyễn Thái Ngọc Duy, Apr 9, 2011
  7. 4/5 Implement new get_pathspec()Nguyễn Thái Ngọc Duy, Apr 9, 2011
  8. 5/5 grep: convert to use the new get_pathspec()Nguyễn Thái Ngọc Duy, Apr 9, 2011
  9. Junio C HamanoApr 10, 2011
  10. Nguyen Thai Ngoc DuyApr 10, 2011
  11. Junio C HamanoApr 9, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.