git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] New get_pathspec()

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 9, 2011, 21:41 UTC
Message-ID
<7vfwpryuey.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1302368060-23827-1-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
Show 5 quoted lines
> [PATCH 1/5] Rename functions in preparation for get_pathspec() restructure
>
>   I figure I cannot bring all commands to the new get_pathspec() at
>   once and remove the old one. So instead I rename the old one so that
>   we can have both implementations running in parallel.

Horribly bad move. Keep the old one running under the same name, and keep the unconverted ones working the same way without new features. Introduce a new infrastructure under a new API function name.

Otherwise you cannot merge in new calles that expect the old get_pathspec() behaviour.

Previous: Nguyen Thai Ngoc Duy
Message 11 of 11 in “New get_pathspec()”
  1. 0/5 New get_pathspec()Nguyễn Thái Ngọc Duy, Apr 9, 2011
  2. 1/5 Rename functions in preparation for get_pathspec() restructureNguyễn Thái Ngọc Duy, Apr 9, 2011
  3. 2/5 Replace has_wildcard with PATHSPEC_NOGLOBNguyễn Thái Ngọc Duy, Apr 9, 2011
  4. Junio C HamanoApr 10, 2011
  5. Nguyen Thai Ngoc DuyApr 10, 2011
  6. 3/5 Convert prefix_pathspec() to produce struct pathspec_itemNguyễn Thái Ngọc Duy, Apr 9, 2011
  7. 4/5 Implement new get_pathspec()Nguyễn Thái Ngọc Duy, Apr 9, 2011
  8. 5/5 grep: convert to use the new get_pathspec()Nguyễn Thái Ngọc Duy, Apr 9, 2011
  9. Junio C HamanoApr 10, 2011
  10. Nguyen Thai Ngoc DuyApr 10, 2011
  11. Junio C HamanoApr 9, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.