git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] t3700: note a .gitignore matching fault

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
May 2, 2011, 15:52 UTC
Message-ID
<BANLkTik=GYXUOeo3hA5yyXfOuBydT40koA@mail.gmail.com>
In-Reply-To
<4DBEC766.8020008@viscovery.net>
2011/5/2 Johannes Sixt <j.sixt@viscovery.net>:
Show 9 quoted lines
> Am 5/2/2011 14:55, schrieb Nguyễn Thái Ngọc Duy:
>> excluded_from_list() fails to handle this case. It too eagerly decides
>> the fate of the whole directory without looking further in.
>
> This has been debated just recently, and I don't think the current
> behavior is broken. See
>
> http://thread.gmane.org/gmane.comp.version-control.git/169913
> http://thread.gmane.org/gmane.comp.version-control.git/157190/focus=157196

Because it's expensive to do does not make it right not to do it. I agree that traversing all the way down just to make the final decision is expensive. But we could at least state that we only support looking for .gitignore down to some level (0 as in current git), or based on .gitignore paths in index, then stop. The point is make it configurable with sane default. It's up to users to decide how they want to pay.

-- 
Duy
Previous: Johannes SixtNext: Junio C Hamano
Message 10 of 18 in “t3700: note a .gitignore matching fault”
  1. 1/3 t3700: note a .gitignore matching faultNguyễn Thái Ngọc Duy, May 2, 2011
  2. 2/3 t1011: fix sparse-checkout initialization and add new fileNguyễn Thái Ngọc Duy, May 2, 2011
  3. 3/3 sparse checkout: do not eagerly decide the fate for whole directoryNguyễn Thái Ngọc Duy, May 2, 2011
  4. Thiago FarinaMay 3, 2011
  5. Nguyen Thai Ngoc DuyMay 3, 2011
  6. Junio C HamanoMay 10, 2011
  7. Nguyen Thai Ngoc DuyMay 11, 2011
  8. 1/3 t3700: note a .gitignore matching faultNguyễn Thái Ngọc Duy, May 2, 2011
  9. Johannes SixtMay 2, 2011
  10. Nguyen Thai Ngoc DuyMay 2, 2011
  11. Junio C HamanoMay 3, 2011
  12. Nguyen Thai Ngoc DuyMay 3, 2011
  13. Junio C HamanoMay 3, 2011
  14. Nguyen Thai Ngoc DuyMay 4, 2011
  15. Nguyen Thai Ngoc DuyMay 4, 2011
  16. Johannes SixtMay 4, 2011
  17. Nguyen Thai Ngoc DuyMay 4, 2011
  18. Junio C HamanoMay 9, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.