From: Nguyen Thai Ngoc Duy Date: Mon, 02 May 2011 15:52:37 GMT Subject: Re: [PATCH 1/3] t3700: note a .gitignore matching fault Message-ID: In-Reply-To: <4DBEC766.8020008@viscovery.net> 2011/5/2 Johannes Sixt : > Am 5/2/2011 14:55, schrieb Nguyễn Thái Ngọc Duy: >> excluded_from_list() fails to handle this case. It too eagerly decides >> the fate of the whole directory without looking further in. > > This has been debated just recently, and I don't think the current > behavior is broken. See > > http://thread.gmane.org/gmane.comp.version-control.git/169913 > http://thread.gmane.org/gmane.comp.version-control.git/157190/focus=157196 Because it's expensive to do does not make it right not to do it. I agree that traversing all the way down just to make the final decision is expensive. But we could at least state that we only support looking for .gitignore down to some level (0 as in current git), or based on .gitignore paths in index, then stop. The point is make it configurable with sane default. It's up to users to decide how they want to pay. -- Duy