Re: [PATCH 3/3] sparse checkout: do not eagerly decide the fate for whole directory

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: May 11, 2011, 12:03 UTC
Message-ID: <BANLkTimxpUwu3SQ9XNv1fUaM-0UwqPNUrg@mail.gmail.com>
In-Reply-To: <7vliyegm98.fsf@alter.siamese.dyndns.org>

On Wed, May 11, 2011 at 6:37 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 16 quoted lines

> Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
>
>>>> +       /* If undecided, use parent directory's decision in defval */
>>> What means "use parent directory's decision"? Could you make this
>>> comment more clearer?
>>
>> Take the example patterns in commit message, we know that we match
>> directory "t" (pattern 1). When we check t/0001-init.sh, no patterns
>> match it. But because it's under "t", so we consider it matched. On
>> the other hand, t/t0000-basic.sh will match pattern 2 and override
>> parent directory's decision.
>
> Somebody ask about the comment you wrote, and you had to explain it.
> Doesn't it tell us something about the readability of the comment?
>
> After all the request was "Could you make it clearer?"

He did not reply whether my further explanation was good enough. Maybe this?

excluded_from_list() can't decide whether the entry matches given patterns. If the current directory is matched before (ie. in defval), then by default the entry is also matched.

-- 
Duy