Re: [PATCH 1/3] t3700: note a .gitignore matching fault
On Wed, May 4, 2011 at 7:41 AM, Nguyen Thai Ngoc Duy <pclouds@gmail.com> wrote:
Show 10 quoted lines
> On Wed, May 4, 2011 at 6:57 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
>>
>>> Yes. But git still silently ignores some rules in the .gitignore.
>>
>> Do you want git to report each and every entry in .gitignore saying "this
>> rule does not apply"? That sounds like madness to me.
>
> This rule should apply, but not because of "efficiency reasons". Not
> just about any rule.
Maybe something like this instead of a implemantation fix?
diff --git a/Documentation/gitignore.txt b/Documentation/gitignore.txt
index 8416f34..81e9d43 100644
--- a/Documentation/gitignore.txt
+++ b/Documentation/gitignore.txt
@@ -71,6 +71,8 @@ PATTERN FORMAT
matching file excluded by a previous pattern will become
included again. If a negated pattern matches, this will
override lower precedence patterns sources.
+ If a directory is excluded by earlier patterns, negated
+ patterns that touch files inside the directory will be ignored.
- If the pattern ends with a slash, it is removed for the
purpose of the following description, but it would only find
--
Duy
Nguyen Thai Ngoc Duy <pclouds@gmail.com>