Re: What's not in 'master', and likely not to be until 1.5.4

From: Steffen Prohaska <prohaska@zib.de>
Date: Jan 18, 2008, 13:23 UTC
Message-ID: <B2CF21CC-2EB0-403C-B7FF-34A2702C81E4@zib.de>
In-Reply-To: <alpine.LSU.1.00.0801181308080.5731@racer.site>

On Jan 18, 2008, at 2:09 PM, Johannes Schindelin wrote:

Show 23 quoted lines

> On Fri, 18 Jan 2008, Steffen Prohaska wrote:
>
>>
>> On Jan 18, 2008, at 11:40 AM, Junio C Hamano wrote:
>>
>>>  * crlf (Steffen Prohaska and Dmitry Potapov)
>>
>> I am working on an alternative to the patch I sent last week. I  
>> hope I
>> can present the two approaches soon.
>>
>> The first approach is a lazy check in crlf_to_git() that warns  
>> about an
>> irreversible conversion; or dies if safecrlf=true.  This is  
>> relatively
>> simple code but at least for git-add a workaround is needed to  
>> suppress
>> printing a warning twice.  The runtime overhead is negligible.
>>
>> The second approach adds a new machinery is_worktree_crlfsafe()
>> that could be run independently of the crlf_to_git() conversion.
>
> From the sound of it, I like the first approach much better.

Ok. I'll start with cleaning up the first approach tomorrow and send resend the patch.

>> I do not expect that this topic will be ready for 1.5.4.
>
> What with our ongoing discussion when to go out of preview phase for
> msysGit, I think this makes sense.

I'll work on creating an improved installer that installs only a subset of the commands. I'll exclude commands that are not yet ready for Windows (e.g. git-svn, ...).

After we have the first version of this installer we can further discuss if we leave the preview phase.

	Steffen