Re: [PATCH] git-remote - Unset core.origin when deleting the default remote

From: Mark Levedahl <mlevedahl@gmail.com>
Date: Jan 15, 2008, 05:02 UTC
Message-ID: <478C3E75.2030801@gmail.com>
In-Reply-To: <20080114110512.GA12723@coredump.intra.peff.net>

Jeff King wrote:

Show 18 quoted lines

> On Sun, Jan 13, 2008 at 11:27:08AM -0500, Mark Levedahl wrote:
>
>   
>> --- a/git-remote.perl
>> +++ b/git-remote.perl
>> @@ -328,6 +328,11 @@ sub rm_remote {
>>  
>>  	$git->command('config', '--remove-section', "remote.$name");
>>  
>> +	my $defremote = $git->config("core.origin");
>> +	if (defined $defremote && $defremote eq $name) {
>> +	       $git->command("config", "--unset", "core.origin");
>> +	}
>> +
>>     
>
> I'm not sure I see the use case that this helps.
>

Just being thorough: the man page claims that "git remote rm foo" removes all mention of remote foo.

Show 7 quoted lines

>     Alternatively, when adding a remote, if it is the _only_ remote (or
>     perhaps if the current core.origin doesn't exist), we could set
>     core.origin which would automagically cover the latter two cases.
>     Although it feels a little too DWIM.
>
> -Peff
>

I suspect anything done in this case is going to suffer from DWIM-itis in some conditions. I can't offer a better argument than the one above.

Mark