Re: [PATCH] Teach remote machinery about remotes.default config variable

From: Mark Levedahl <mlevedahl@gmail.com>
Date: Jan 11, 2008, 20:52 UTC
Message-ID: <30e4a070801111252s4e17b9c4m62adeb9032963e66@mail.gmail.com>
In-Reply-To: <7v1w8o4ws0.fsf@gitster.siamese.dyndns.org>

On Jan 11, 2008 3:00 AM, Junio C Hamano <gitster@pobox.com> wrote:

>
> Does this mean "default" is now a new reserved word that cannot
> be used as "git remote update default"?

oops...git-remote already has a (partially undocumented) use for remotes.* as well as remote.*, so I need another variable name, probably core.origin to avoid either defining new namespace or polluting one reserved for arbitrary end-user use. Will resend patches later tonight.

>
> However, it is a bit hard to judge how much of inconvenience it
> really is in your real life that the current behaviour does not
> allow you to.

I believe I addressed this in the thread with Dscho.

Show 8 quoted lines

> >       git_config(handle_config);
> > +     if (!default_remote_name) {
> > +                     default_remote_name = remotes_default_name ?
> > +                             remotes_default_name : xstrdup("origin");
> > +     }
>
> Is this a bit too deep indentation?
>

will fix.

Mark