Re: [PATCH] Teach remote machinery about remotes.default config variable

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 14, 2008, 01:50 UTC
Message-ID: <7vir1xmazm.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LSU.1.00.0801132224540.8333@wbgn129.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> I never understood why people want to complicate things by being able to 
> name default _keys_ differently.  Why not letting "origin" being the 
> default being pulled from, and be done with it?

That happens to match my personal feeling.

HOWEVER.

We treat 'origin' in a special way when you do this:

	$ git clone somewhere new.git
        $ cd new.git
        $ git checkout HEAD^0
        $ git pull

And we already have "clone -o" and claim to support that option. I think that it is very reasonable from the consistency point of view to make sure that the following sequence treats 'frotz' the same special way the above treats 'origin' specially:

	$ git clone -o frotz somewhere new.git
        $ cd new.git
        $ git checkout HEAD^0
        $ git pull

A purist alternative is to deprecate "git clone -o" and eventually remove it.

Note that I was agreeing only with this specific aspect of the argument. I am not at all interested in getting involved in refining or re-defining the existing submodule semantics this late in the cycle before 1.5.4. But I can very well see that fixing this specific inconsistency can be separated out from the rest of Mark's series and viewed as a set of trivially correct fixes.

> Besides, I _really_ do not understand why we have such a
> discussion in rc phase.  There are _many_ more interesting
> discussions now that _also_ do not belong into a freeze phase.

Currently the ones I looked at and consider possible 1.5.4 material are http-push fixes from Grégoire Barbier and parse_commit_buffer() tightening from Martin Koegler.

Recently I looked at the following patches and topics but I do not think any of them belongs to 1.5.4. None of them is obvious and trivially correct fix to regressions or serious existing bugs:

 * compress/decompress abstraction (Marco)

 * crlf (Steffen Prohaska and Dmitry Potapov)

 * whitespace error: "cr at eol is ok" (me)

 * various conflicting submodule changes(Ping Yin, Mark
   Levedahl, Imran M Yousuf)

 * unconfigured ident safety (Stephen Sinclair)

 * gitweb feed from commit to commitdiff (Florian La Rouche --
   Jakub seems to be on top of this so I am not worried about it
   too much).

 * color.ui (Matthias Kestenholz)

 * test scripts to use valgrind (Jeff King, but there was another
   one in the past -- can their efforts compared and coordinated
   better?).

 * various lstat(2) reduction changes (me).

 * pathname safety on insane filesystems (Linus, Robin
   Rosenberg, me).

(yes, some of the above list do not even have any code).

I am hoping that authors will resend the ones they really care about after 1.5.4, as I do not want to take patches early.

Thanks.