Re: [RFC/PATCH 0/3] fast-import: give importers access to the object store

From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Sep 24, 2010, 23:44 UTC
Message-ID: <AANLkTinsotbGpg1LAXA+UchBHQrBK12tkX+o4tOFWUOF@mail.gmail.com>
In-Reply-To: <20100924194313.GA8114@burratino>

Heya,

On Fri, Sep 24, 2010 at 21:43, Jonathan Nieder <jrnieder@gmail.com> wrote:

> Yes, I guess "feature report-fd=3" is a protocol layering violation.
> Unfortunately import-marks and export-marks have already set a
> precedent.

I don't agree, they (can) use a relative path name, allow the stream to be re-used at a different location.

> Well-behaved streams could use that and rely on the fd to be set on
> the command line, while poorly-behaved streams could still use
> "feature report-fd=whatever" to get the effect of --report-fd=whatever
> and avoid breaking UI consistency.

Additionally you could have the commandline override whatever the stream sets, so that the stream can be re-used as long as the user specifies the appropriate commandline arguments?

-- 
Cheers,

Sverre Rabbelier