Re: [RFC/PATCH 0/3] fast-import: give importers access to the object store
- From
Sam Vilain <sam@vilain.net>
- Date
- Sep 16, 2010, 00:14 UTC
- Message-ID
- <1284596048.3298.3.camel@wilber>
- In-Reply-To
- <20100905031528.GA2344@burratino>
On Sat, 2010-09-04 at 22:15 -0500, Jonathan Nieder wrote:
Show 9 quoted lines
> It works like this: > > frontend: > feature report-fd=3 > commit refs/heads/master > ... revision 1 ... > > importer: > abc7856cba76bca87a65bca76bca8bca98bca78bca76
This is probably quite a late comment, but I don't think that 'report-fd=3' is a good idea in a protocol like this. It should not take an argument and just respond down the appropriate selected file descriptor. ie, default to standard output. If standard input is a socket, then use that bidirectionally. If --report-fd is used on the command line, use that.
Sam