Re: [PATCH 03/24] t9300 (fast-import): guard "export large marks" test setup
- From
Raja R Harinath <harinath@hurrynot.org>
- Date
- Sep 24, 2010, 10:56 UTC
- Message-ID
- <87aan7e7f5.fsf@hariville.hurrynot.org>
- In-Reply-To
- <20100924093847.GE22658@kytes>
Hi,
Ramkumar Ramachandra <artagnon@gmail.com> writes:
> Jonathan Nieder writes:
[snip]
Show 7 quoted lines
>> + cat >input.commit <<-EOF && >> + commit refs/heads/verify--dump-marks >> + committer $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> $GIT_COMMITTER_DATE >> + data <<COMMIT >> + test the sparse array dumping routines with exponentially growing marks > > Ok, so we want marks to grow exponentially.
Just to clarify, this code is already in the tree. Jonathan is only re-indenting it and moving it inside a test_expect_success.
[snip]
Show 6 quoted lines
>> + i=0 && >> + l=4 && >> + m=6 && >> + n=7 && > > Maybe use slightly less cryptic variable names?
I expect these are fairly idiomatic, except maybe for 'n', which could be replaced by 'u', I guess.
[snip]
Show 6 quoted lines
>> + l=$(($l + $l)) && >> + m=$(($m + $m)) && >> + n=$(($l + $n)) && > > Maybe l=$(($l * 2)) and similarly for m to emphasize that they're > doubling in every loop iteration?
Hmm, $l appears twice, that's literally doubling, isn't it ;-)
- Hari