git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix expected values of setup tests on Windows

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
Jan 1, 2011, 03:46 UTC
Message-ID
<AANLkTinWdGDtxPk24OBQnJP8fdHW9gYNDn46YKRGTWoB@mail.gmail.com>
In-Reply-To
<201012311711.06989.j6t@kdbg.org>
On Fri, Dec 31, 2010 at 11:11 PM, Johannes Sixt <j6t@kdbg.org> wrote:
Show 13 quoted lines
>> in your patch does not. Does bash auto convert value in
>> TRASH_DIRECTORY="$TE..." line?
>
> No. When this line is executed:
>
> TEST_DIRECTORY=$(pwd)
>
> $(pwd) still has its default behavior to return the POSIX style path. pwd is
> redefined to pwd -W only later.
>
> I'm hesitant to redefine pwd earlier in test-lib.sh, though, because we would
> have to audit all uses of TEST_DIRECTORY for whether POSIX style paths or
> drive-letter paths are needed.
Ah I missed that. Thanks. Ack from me.
-- 
Duy
Previous: Junio C HamanoNext: Johannes Sixt
Message 6 of 12 in “Re: [PATCH] Fix expected values of setup tests on Windows”
  1. Nguyen Thai Ngoc DuyDec 31, 2010
  2. Johannes SixtDec 31, 2010
  3. Jonathan NiederDec 31, 2010
  4. Johannes SixtDec 31, 2010
  5. Junio C HamanoJan 2, 2011
  6. Nguyen Thai Ngoc DuyJan 1, 2011
  7. 2/2 t/README: hint about using $(pwd) rather than $PWD in testsJohannes Sixt, Jan 11, 2011
  8. Jonathan NiederJan 11, 2011
  9. Johannes SixtJan 11, 2011
  10. Jonathan NiederJan 11, 2011
  11. Johannes SixtJan 11, 2011
  12. Junio C HamanoJan 11, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.