Re: [PATCH 2/2] t/README: hint about using $(pwd) rather than $PWD in tests
- From
Johannes Sixt <j.sixt@viscovery.net>
- Date
- Jan 11, 2011, 08:15 UTC
- Message-ID
- <4D2C11A5.4050709@viscovery.net>
- In-Reply-To
- <20110111075441.GB9445@burratino>
Am 1/11/2011 8:54, schrieb Jonathan Nieder:
> Perhaps it is also worth explaining the cases where $PWD is needed? > > By contrast, when a passing a path to git or constructing a URL, > use $PWD.
The first part of the "or" is not true: you can pass the result of $(pwd) to a command, and it means the same as $PWD; I would even recommend against $PWD so that a reader does not have to wonder "why pass $PWD, but check for $(pwd)?"
The second part I don't know whether it is true: I haven't noticed a pattern where people did it the wrong way, therefore, I'don't even know whether $PWD is really *always* required. Do *you* know?
Show 5 quoted lines
> It makes a difference on Windows, where > > - $(pwd) is a Windows-style path such as git might output, and > - $PWD is a Unix-style path that the shell (MSYS bash) will > mangle before passing to native apps like git.
This information is already included by reference to 4114156ae9.
-- Hannes