git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] t/README: hint about using $(pwd) rather than $PWD in tests

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Jan 11, 2011, 08:54 UTC
Message-ID
<4D2C1AAE.1040002@viscovery.net>
In-Reply-To
<20110111083729.GD9445@burratino>
Am 1/11/2011 9:37, schrieb Jonathan Nieder:
> I suspect that the reader will end up wondering "why does this have to
> be so complicated" no matter what.

Unfortunately, yes. Therefore, I'd like to keep the paragraph minimal, focused on how expected values should be constructed, which is where errors will happen primarily.

Show 10 quoted lines
>>>       It makes a difference on Windows, where
>>>
>>> 	 - $(pwd) is a Windows-style path such as git might output, and
>>> 	 - $PWD is a Unix-style path that the shell (MSYS bash) will
>>> 	   mangle before passing to native apps like git.
>>
>> This information is already included by reference to 4114156ae9.
> 
> ... but if we can summarize it nicely, we can save the reader a
> step, no?

I don't think so: it's not complete enough. Readers will ask: "So what?" Digging archives or a three paragraph follow-up explanation on the ML will be required anyway.

> Anyway, what you have already written is useful; clearing up these
> details would just be icing on the top.
OK, thanks for a review.
-- Hannes
Previous: Jonathan NiederNext: Junio C Hamano
Message 11 of 12 in “Re: [PATCH] Fix expected values of setup tests on Windows”
  1. Nguyen Thai Ngoc DuyDec 31, 2010
  2. Johannes SixtDec 31, 2010
  3. Jonathan NiederDec 31, 2010
  4. Johannes SixtDec 31, 2010
  5. Junio C HamanoJan 2, 2011
  6. Nguyen Thai Ngoc DuyJan 1, 2011
  7. 2/2 t/README: hint about using $(pwd) rather than $PWD in testsJohannes Sixt, Jan 11, 2011
  8. Jonathan NiederJan 11, 2011
  9. Johannes SixtJan 11, 2011
  10. Jonathan NiederJan 11, 2011
  11. Johannes SixtJan 11, 2011
  12. Junio C HamanoJan 11, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.