git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix expected values of setup tests on Windows

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 2, 2011, 01:31 UTC
Message-ID
<7v62u8hz01.fsf@alter.siamese.dyndns.org>
In-Reply-To
<201012312321.31294.j6t@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
Show 20 quoted lines
> On Freitag, 31. Dezember 2010, Jonathan Nieder wrote:
>> Johannes Sixt wrote:
>> > On Freitag, 31. Dezember 2010, Nguyen Thai Ngoc Duy wrote:
>> >> in your patch does not. Does bash auto convert value in
>> >> TRASH_DIRECTORY="$TE..." line?
>> >
>> > No. When this line is executed:
>> >
>> > TEST_DIRECTORY=$(pwd)
>> >
>> > $(pwd) still has its default behavior to return the POSIX style path. pwd
>> > is redefined to pwd -W only later.
>>
>> Would it make sense to change it to
>>
>>  TEST_DIRECTORY=$PWD
>>
>> for clarity and robustness against code movement, then?
>
> Yes, that would make sense.

It will be very much appreciated to add a few sentences to clarify this to "Do's and don'ts" section of t/README if you are re-rolling this. Thanks.

Previous: Johannes SixtNext: Nguyen Thai Ngoc Duy
Message 5 of 12 in “Re: [PATCH] Fix expected values of setup tests on Windows”
  1. Nguyen Thai Ngoc DuyDec 31, 2010
  2. Johannes SixtDec 31, 2010
  3. Jonathan NiederDec 31, 2010
  4. Johannes SixtDec 31, 2010
  5. Junio C HamanoJan 2, 2011
  6. Nguyen Thai Ngoc DuyJan 1, 2011
  7. 2/2 t/README: hint about using $(pwd) rather than $PWD in testsJohannes Sixt, Jan 11, 2011
  8. Jonathan NiederJan 11, 2011
  9. Johannes SixtJan 11, 2011
  10. Jonathan NiederJan 11, 2011
  11. Johannes SixtJan 11, 2011
  12. Junio C HamanoJan 11, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.