git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 01/14] msvc: Fix compilation errors in compat/win32/sys/poll.c

From
Erik Faye-Lund <kusmabite@gmail.com>
Date
Dec 4, 2010, 21:12 UTC
Message-ID
<AANLkTinDoeYarLQLtZ327a7Us0cvaN42NFCoYorwMsT-@mail.gmail.com>
In-Reply-To
<4CFA8E64.6070402@ramsay1.demon.co.uk>
On Sat, Dec 4, 2010 at 7:54 PM, Ramsay Jones <ramsay@ramsay1.demon.co.uk> wrote:
Show 30 quoted lines
>
> The msvc winsock2.h header file conditionally defines or declares
> poll() related symbols which cause many macro redefinition errors,
> a struct type redefinition error and syntax errors. These symbols
> are defined in support of the WSAPoll() API, new in Windows Vista,
> when the symbol _WIN32_WINNT is defined and _WIN32_WINNT >= 0x0600.
>
> In order to avoid the compilation errors, we set _WIN32_WINNT to
> 0x0502 (which would target Windows Server 2003) prior to including
> the winsock2.h header file.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>  compat/win32/sys/poll.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/compat/win32/sys/poll.c b/compat/win32/sys/poll.c
> index 7e74ebe..708a6c9 100644
> --- a/compat/win32/sys/poll.c
> +++ b/compat/win32/sys/poll.c
> @@ -34,6 +34,9 @@
>
>  #if (defined _WIN32 || defined __WIN32__) && ! defined __CYGWIN__
>  # define WIN32_NATIVE
> +# if defined (_MSC_VER)
> +#  define _WIN32_WINNT 0x0502
> +# endif
>  # include <winsock2.h>
>  # include <windows.h>
>  # include <io.h>
I have an almost identical patch in my msvc-tree, so FWIW:
Acked-by: Erik Faye-Lund <kusmabite@gmail.com>
Previous: Ramsay JonesNext: Johannes Sixt
Message 4 of 8 in “msvc: Fix compilation errors in compat/win32/sys/poll.c”
  1. 01/14 msvc: Fix compilation errors in compat/win32/sys/poll.cRamsay Jones, Dec 4, 2010
  2. Jonathan NiederDec 4, 2010
  3. Ramsay JonesDec 7, 2010
  4. Erik Faye-LundDec 4, 2010
  5. Johannes SixtDec 4, 2010
  6. Ramsay JonesDec 8, 2010
  7. Johannes SixtDec 8, 2010
  8. Johannes SixtDec 11, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.